All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH][2.6.12-rc4][SATA] sil driver - Blacklist Maxtor disk
@ 2005-05-24 16:27 Shawn Starr
  2005-05-27  4:01 ` Eric D. Mudama
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn Starr @ 2005-05-24 16:27 UTC (permalink / raw)
  To: linux-kernel, linux-ide, jgarzik

Yes, I know we shouldn't do this, but at the current
time, this seems to fix DMA READ/WRITE timeout
problems. This also may fix the sata_nv driver as
well, but this seems indicate that there is a lowlevel
problem with the SATA subsystem. 

Signed-off-by: Shawn Starr <shawn.starr@rogers.com>

--- sata_sil.c.old      2005-05-24 12:19:20.312197269
-0400
+++ sata_sil.c  2005-05-11 14:05:26.000000000 -0400
@@ -93,6 +93,7 @@ struct sil_drivelist {
        { "ST380011ASL",        SIL_QUIRK_MOD15WRITE
},
        { "ST3120022ASL",       SIL_QUIRK_MOD15WRITE
},
        { "ST3160021ASL",       SIL_QUIRK_MOD15WRITE
},
+       { "Maxtor 6Y080M0",     SIL_QUIRK_MOD15WRITE
},
        { "Maxtor 4D060H3",     SIL_QUIRK_UDMA5MAX },
        { }
 };


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][2.6.12-rc4][SATA] sil driver - Blacklist Maxtor disk
  2005-05-24 16:27 [PATCH][2.6.12-rc4][SATA] sil driver - Blacklist Maxtor disk Shawn Starr
@ 2005-05-27  4:01 ` Eric D. Mudama
  2005-05-27  4:09   ` Shawn Starr
  0 siblings, 1 reply; 3+ messages in thread
From: Eric D. Mudama @ 2005-05-27  4:01 UTC (permalink / raw)
  To: Shawn Starr; +Cc: linux-kernel, linux-ide, jgarzik

I don't believe that drive is vulnerable to the traditionally
described SI issue, as it's based on  Marvell bridge IP.  If that
drive was vulnerable, so would be the drives of more than one other
large vendor.  I would bet something else is actually the root cause,
and by using smaller transfers or something you're just hiding the
race condition, not fixing a root cause.

(obviously i'd love to see a bus trace of the hang in action, but not
everyone can swap their cars for bus analyzers...)

--eric

On 5/24/05, Shawn Starr <shawn.starr@rogers.com> wrote:
> Yes, I know we shouldn't do this, but at the current
> time, this seems to fix DMA READ/WRITE timeout
> problems. This also may fix the sata_nv driver as
> well, but this seems indicate that there is a lowlevel
> problem with the SATA subsystem.
> 
> Signed-off-by: Shawn Starr <shawn.starr@rogers.com>
> 
> --- sata_sil.c.old      2005-05-24 12:19:20.312197269
> -0400
> +++ sata_sil.c  2005-05-11 14:05:26.000000000 -0400
> @@ -93,6 +93,7 @@ struct sil_drivelist {
>         { "ST380011ASL",        SIL_QUIRK_MOD15WRITE
> },
>         { "ST3120022ASL",       SIL_QUIRK_MOD15WRITE
> },
>         { "ST3160021ASL",       SIL_QUIRK_MOD15WRITE
> },
> +       { "Maxtor 6Y080M0",     SIL_QUIRK_MOD15WRITE
> },
>         { "Maxtor 4D060H3",     SIL_QUIRK_UDMA5MAX },
>         { }
>  };
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][2.6.12-rc4][SATA] sil driver - Blacklist Maxtor disk
  2005-05-27  4:01 ` Eric D. Mudama
@ 2005-05-27  4:09   ` Shawn Starr
  0 siblings, 0 replies; 3+ messages in thread
From: Shawn Starr @ 2005-05-27  4:09 UTC (permalink / raw)
  To: Eric D. Mudama; +Cc: linux-kernel, linux-ide, jgarzik

Any way i can get you the bus trace? the box Im using is 
'disposable' (reinstallable)

On May 27, 2005 00:01, Eric D. Mudama wrote:

> I don't believe that drive is vulnerable to the traditionally
> described SI issue, as it's based on  Marvell bridge IP.  If that
> drive was vulnerable, so would be the drives of more than one other
> large vendor.  I would bet something else is actually the root cause,
> and by using smaller transfers or something you're just hiding the
> race condition, not fixing a root cause.
>
> (obviously i'd love to see a bus trace of the hang in action, but not
> everyone can swap their cars for bus analyzers...)
>
> --eric
>
> On 5/24/05, Shawn Starr <shawn.starr@rogers.com> wrote:
> > Yes, I know we shouldn't do this, but at the current
> > time, this seems to fix DMA READ/WRITE timeout
> > problems. This also may fix the sata_nv driver as
> > well, but this seems indicate that there is a lowlevel
> > problem with the SATA subsystem.
> >
> > Signed-off-by: Shawn Starr <shawn.starr@rogers.com>
> >
> > --- sata_sil.c.old      2005-05-24 12:19:20.312197269
> > -0400
> > +++ sata_sil.c  2005-05-11 14:05:26.000000000 -0400
> > @@ -93,6 +93,7 @@ struct sil_drivelist {
> >         { "ST380011ASL",        SIL_QUIRK_MOD15WRITE
> > },
> >         { "ST3120022ASL",       SIL_QUIRK_MOD15WRITE
> > },
> >         { "ST3160021ASL",       SIL_QUIRK_MOD15WRITE
> > },
> > +       { "Maxtor 6Y080M0",     SIL_QUIRK_MOD15WRITE
> > },
> >         { "Maxtor 4D060H3",     SIL_QUIRK_UDMA5MAX },
> >         { }
> >  };
> >
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-05-27  4:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-24 16:27 [PATCH][2.6.12-rc4][SATA] sil driver - Blacklist Maxtor disk Shawn Starr
2005-05-27  4:01 ` Eric D. Mudama
2005-05-27  4:09   ` Shawn Starr

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.