Re: [oe-core][PATCH] Make Python IPv6 aware

[Paul Eggleton <paul.eggleton@linux.intel.com>]

Hi Dan,

On Monday 03 June 2013 16:12:14 danismostlikely@gmail.com wrote:
> From: Dan McGregor <dan.mcgregor@usask.ca>
> 
> Wrap this around DISTRO_FEATURES, because we don't want it
> unconditionally enabled.
> ---
>  meta/recipes-devtools/python/python.inc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-devtools/python/python.inc
> b/meta/recipes-devtools/python/python.inc index d0ed55b..4618eb3 100644
> --- a/meta/recipes-devtools/python/python.inc
> +++ b/meta/recipes-devtools/python/python.inc
> @@ -19,6 +19,7 @@ inherit autotools
>  PYTHONLSBOPTS = "--with-wctype-functions"
>  PYTHONLSBOPTS_linuxstdbase = "ac_cv_sizeof_off_t=8"
> 
> +ENABLE_IPV6 = "--enable-ipv6=${@base_contains('DISTRO_FEATURES', 'ipv6',
> 'yes', 'no', d)}" EXTRA_OECONF = "\
>    --with-threads \
>    --with-pymalloc \
> @@ -27,5 +28,6 @@ EXTRA_OECONF = "\
>    --with-signal-module \
>    --with-wctype-functions \
>    --enable-shared \
> +  ${ENABLE_IPV6} \
>    ${PYTHONLSBOPTS} \
>  "

OE-Core patches need to go to openembedded-core@lists.openembedded.org rather 
than this list. Also, the shortlog (first line of the commit message) should 
start with the recipe / component being changed, so in this case it should be 
something like "python: enable IPv6 based on DISTRO_FEATURES". Additionally, 
do you need to use an additional ENABLE_IPV6 variable here or can you just 
include the expression within the EXTRA_OECONF expression?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre