* [oe-core][PATCH] Make Python IPv6 aware @ 2013-06-03 22:12 danismostlikely 2013-06-03 22:12 ` danismostlikely 2013-06-04 12:06 ` Lukas Bulwahn 0 siblings, 2 replies; 5+ messages in thread From: danismostlikely @ 2013-06-03 22:12 UTC (permalink / raw) To: openembedded-devel I found that gateone would crash with a socket error when Python isn't compiled with IPv6 support. This patch enables it when DISTRO_FEATURES includes ipv6. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [oe-core][PATCH] Make Python IPv6 aware 2013-06-03 22:12 [oe-core][PATCH] Make Python IPv6 aware danismostlikely @ 2013-06-03 22:12 ` danismostlikely 2013-06-03 22:33 ` Paul Eggleton 2013-06-04 12:06 ` Lukas Bulwahn 1 sibling, 1 reply; 5+ messages in thread From: danismostlikely @ 2013-06-03 22:12 UTC (permalink / raw) To: openembedded-devel; +Cc: Dan McGregor From: Dan McGregor <dan.mcgregor@usask.ca> Wrap this around DISTRO_FEATURES, because we don't want it unconditionally enabled. --- meta/recipes-devtools/python/python.inc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/recipes-devtools/python/python.inc b/meta/recipes-devtools/python/python.inc index d0ed55b..4618eb3 100644 --- a/meta/recipes-devtools/python/python.inc +++ b/meta/recipes-devtools/python/python.inc @@ -19,6 +19,7 @@ inherit autotools PYTHONLSBOPTS = "--with-wctype-functions" PYTHONLSBOPTS_linuxstdbase = "ac_cv_sizeof_off_t=8" +ENABLE_IPV6 = "--enable-ipv6=${@base_contains('DISTRO_FEATURES', 'ipv6', 'yes', 'no', d)}" EXTRA_OECONF = "\ --with-threads \ --with-pymalloc \ @@ -27,5 +28,6 @@ EXTRA_OECONF = "\ --with-signal-module \ --with-wctype-functions \ --enable-shared \ + ${ENABLE_IPV6} \ ${PYTHONLSBOPTS} \ " -- 1.8.1.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [oe-core][PATCH] Make Python IPv6 aware 2013-06-03 22:12 ` danismostlikely @ 2013-06-03 22:33 ` Paul Eggleton 0 siblings, 0 replies; 5+ messages in thread From: Paul Eggleton @ 2013-06-03 22:33 UTC (permalink / raw) To: danismostlikely; +Cc: Dan McGregor, openembedded-devel Hi Dan, On Monday 03 June 2013 16:12:14 danismostlikely@gmail.com wrote: > From: Dan McGregor <dan.mcgregor@usask.ca> > > Wrap this around DISTRO_FEATURES, because we don't want it > unconditionally enabled. > --- > meta/recipes-devtools/python/python.inc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta/recipes-devtools/python/python.inc > b/meta/recipes-devtools/python/python.inc index d0ed55b..4618eb3 100644 > --- a/meta/recipes-devtools/python/python.inc > +++ b/meta/recipes-devtools/python/python.inc > @@ -19,6 +19,7 @@ inherit autotools > PYTHONLSBOPTS = "--with-wctype-functions" > PYTHONLSBOPTS_linuxstdbase = "ac_cv_sizeof_off_t=8" > > +ENABLE_IPV6 = "--enable-ipv6=${@base_contains('DISTRO_FEATURES', 'ipv6', > 'yes', 'no', d)}" EXTRA_OECONF = "\ > --with-threads \ > --with-pymalloc \ > @@ -27,5 +28,6 @@ EXTRA_OECONF = "\ > --with-signal-module \ > --with-wctype-functions \ > --enable-shared \ > + ${ENABLE_IPV6} \ > ${PYTHONLSBOPTS} \ > " OE-Core patches need to go to openembedded-core@lists.openembedded.org rather than this list. Also, the shortlog (first line of the commit message) should start with the recipe / component being changed, so in this case it should be something like "python: enable IPv6 based on DISTRO_FEATURES". Additionally, do you need to use an additional ENABLE_IPV6 variable here or can you just include the expression within the EXTRA_OECONF expression? Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe-core][PATCH] Make Python IPv6 aware 2013-06-03 22:12 [oe-core][PATCH] Make Python IPv6 aware danismostlikely 2013-06-03 22:12 ` danismostlikely @ 2013-06-04 12:06 ` Lukas Bulwahn 2013-06-11 7:51 ` Khem Raj 1 sibling, 1 reply; 5+ messages in thread From: Lukas Bulwahn @ 2013-06-04 12:06 UTC (permalink / raw) To: openembedded-devel Hi Dan, in my layer, I simply activate IPv6 support for python with a simple bbappend file: https://github.com/bmwcarit/meta-ros/blob/master/recipes-devtools/python/pyt hon_2.7.3.bbappend Lukas > -----Ursprüngliche Nachricht----- > Von: openembedded-devel-bounces@lists.openembedded.org > [mailto:openembedded-devel-bounces@lists.openembedded.org] Im Auftrag > von danismostlikely@gmail.com > Gesendet: Dienstag, 4. Juni 2013 00:12 > An: openembedded-devel@lists.openembedded.org > Betreff: [oe] [oe-core][PATCH] Make Python IPv6 aware > > I found that gateone would crash with a socket error when Python isn't > compiled with IPv6 support. This patch enables it when DISTRO_FEATURES > includes ipv6. > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [oe-core][PATCH] Make Python IPv6 aware 2013-06-04 12:06 ` Lukas Bulwahn @ 2013-06-11 7:51 ` Khem Raj 0 siblings, 0 replies; 5+ messages in thread From: Khem Raj @ 2013-06-11 7:51 UTC (permalink / raw) To: openembeded-devel On Tue, Jun 4, 2013 at 5:06 AM, Lukas Bulwahn <lukas.bulwahn@oss.bmw-carit.de> wrote: > Hi Dan, > > in my layer, I simply activate IPv6 support for python with a simple > bbappend file: > > https://github.com/bmwcarit/meta-ros/blob/master/recipes-devtools/python/pyt > hon_2.7.3.bbappend the patch is worth it only thing is it needs to go to right ml with Pauls comments addressed > > Lukas > >> -----Ursprüngliche Nachricht----- >> Von: openembedded-devel-bounces@lists.openembedded.org >> [mailto:openembedded-devel-bounces@lists.openembedded.org] Im Auftrag >> von danismostlikely@gmail.com >> Gesendet: Dienstag, 4. Juni 2013 00:12 >> An: openembedded-devel@lists.openembedded.org >> Betreff: [oe] [oe-core][PATCH] Make Python IPv6 aware >> >> I found that gateone would crash with a socket error when Python isn't >> compiled with IPv6 support. This patch enables it when DISTRO_FEATURES >> includes ipv6. >> >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-11 7:51 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-06-03 22:12 [oe-core][PATCH] Make Python IPv6 aware danismostlikely 2013-06-03 22:12 ` danismostlikely 2013-06-03 22:33 ` Paul Eggleton 2013-06-04 12:06 ` Lukas Bulwahn 2013-06-11 7:51 ` Khem Raj
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.