Re: [PATCH] arm64: dts: mt8173-evb: Add PMIC support

[Matthias Brugger <matthias.bgg@gmail.com>]

On Tuesday, July 07, 2015 11:09:50 AM Eddie Huang wrote:
> On Mon, 2015-07-06 at 18:39 +0200, Matthias Brugger wrote:
> > On Monday, July 06, 2015 03:43:57 PM Eddie Huang wrote:
> > > On Mon, 2015-06-22 at 21:19 +0800, Henry Chen wrote:
> > > > From: Eddie Huang <eddie.huang@mediatek.com>
> 
> [...]
> 
> > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> > > > b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts index 43d5401..b967914
> > > > 100644
> > > > --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> > > > +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts
> > > > @@ -33,6 +33,180 @@
> > > > 
> > > >  	chosen { };
> > > >  
> > > >  };
> > > > 
> > > > +&pwrap {
> > > > +	pmic: mt6397 {
> > > > +		compatible = "mediatek,mt6397";
> > > > +		interrupt-parent = <&pio>;
> > > > +		interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
> > > > +		interrupt-controller;
> > > > +		#interrupt-cells = <2>;
> > > > +
> > > > +		mt6397regulator: mt6397regulator {
> > > > +			compatible = "mediatek,mt6397-regulator";
> > > > +			mt6397_vpca15_reg: buck_vpca15 {
> > > > +				regulator-compatible = "buck_vpca15";
> > > > +				regulator-name = "vpca15";
> > > > +				regulator-min-microvolt = < 700000>;
> > > > +				regulator-max-microvolt = <1350000>;
> > > > +				regulator-ramp-delay = <12500>;
> > > > +				regulator-always-on;
> > > 
> > > I see you pull da9211 regulator dts patch, but not this one. How about
> > > this patch ?
> > 
> > I inserted some new-lines and added it to v4.2-next/arm64
> 
> Thanks the pull. Normally we put alias node in alphabetical order, make
> later merge more easily. I think you can do the modification and squeeze
> into the same commit.
> 

I used the order of the dtsi file, but I think your approach is more straight 
forward. I will change that.

Thanks for your comment.
Matthias