* Re: [PATCH] [media] videobuf-dma-contig: restore buffer mapping for uncached bufers
[not found] <1340360046-23429-1-git-send-email-prabhakar.lad@ti.com>
@ 2012-06-22 15:28 ` Federico Vaga
2012-06-22 16:45 ` Hans Verkuil
0 siblings, 1 reply; 6+ messages in thread
From: Federico Vaga @ 2012-06-22 15:28 UTC (permalink / raw)
To: Prabhakar Lad
Cc: LMML, dlos, Hans Verkuil, Mauro Carvalho Chehab, Laurent Pinchart,
Hadli Manjunath
> from commit a8f3c203e19b702fa5e8e83a9b6fb3c5a6d1cce4
> restore the mapping scheme for uncached buffers,
> which was changed in a common scheme for cached and uncached.
> This apparently was wrong, and was probably intended only for cached
> buffers. the fix fixes the crash observed while mapping uncached
> buffers.
>
> Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> Signed-off-by: Hadli, Manjunath <manjunath.hadli@ti.com>
Acked-by: Federico Vaga <federico.vaga@gmail.com>
I tested the patch on the STA2X11 board.
--
Federico Vaga
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [media] videobuf-dma-contig: restore buffer mapping for uncached bufers
2012-06-22 15:28 ` [PATCH] [media] videobuf-dma-contig: restore buffer mapping for uncached bufers Federico Vaga
@ 2012-06-22 16:45 ` Hans Verkuil
2012-06-22 16:53 ` Federico Vaga
0 siblings, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2012-06-22 16:45 UTC (permalink / raw)
To: Prabhakar Lad
Cc: Federico Vaga, LMML, dlos, Mauro Carvalho Chehab,
Laurent Pinchart, Hadli Manjunath
On Fri June 22 2012 17:28:04 Federico Vaga wrote:
> > from commit a8f3c203e19b702fa5e8e83a9b6fb3c5a6d1cce4
> > restore the mapping scheme for uncached buffers,
> > which was changed in a common scheme for cached and uncached.
> > This apparently was wrong, and was probably intended only for cached
> > buffers. the fix fixes the crash observed while mapping uncached
> > buffers.
> >
> > Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> > Signed-off-by: Hadli, Manjunath <manjunath.hadli@ti.com>
>
> Acked-by: Federico Vaga <federico.vaga@gmail.com>
>
> I tested the patch on the STA2X11 board.
>
>
Was this patch ever posted on linux-media? I didn't see it on the mailinglist,
nor in my personal inbox.
Perhaps something went wrong?
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [media] videobuf-dma-contig: restore buffer mapping for uncached bufers
2012-06-22 16:45 ` Hans Verkuil
@ 2012-06-22 16:53 ` Federico Vaga
2012-06-23 9:19 ` Hans Verkuil
0 siblings, 1 reply; 6+ messages in thread
From: Federico Vaga @ 2012-06-22 16:53 UTC (permalink / raw)
To: Hans Verkuil
Cc: Prabhakar Lad, LMML, dlos, Mauro Carvalho Chehab,
Laurent Pinchart, Hadli Manjunath
In data venerdì 22 giugno 2012 18:45:31, Hans Verkuil ha scritto:
> On Fri June 22 2012 17:28:04 Federico Vaga wrote:
> > > from commit a8f3c203e19b702fa5e8e83a9b6fb3c5a6d1cce4
> > > restore the mapping scheme for uncached buffers,
> > > which was changed in a common scheme for cached and uncached.
> > > This apparently was wrong, and was probably intended only for
> > > cached
> > > buffers. the fix fixes the crash observed while mapping uncached
> > > buffers.
> > >
> > > Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> > > Signed-off-by: Hadli, Manjunath <manjunath.hadli@ti.com>
> >
> > Acked-by: Federico Vaga <federico.vaga@gmail.com>
> >
> > I tested the patch on the STA2X11 board.
>
> Was this patch ever posted on linux-media? I didn't see it on the
> mailinglist, nor in my personal inbox.
>
> Perhaps something went wrong?
I recived the email as CC and linux-media was the main destination.
Davinci list was also added as CC and you can find the patch there:
http://www.mail-archive.com/davinci-linux-open-
source@linux.davincidsp.com/msg22998.html
Something went wrong.
--
Federico Vaga
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [media] videobuf-dma-contig: restore buffer mapping for uncached bufers
2012-06-22 16:53 ` Federico Vaga
@ 2012-06-23 9:19 ` Hans Verkuil
2012-06-25 11:43 ` Hans Verkuil
0 siblings, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2012-06-23 9:19 UTC (permalink / raw)
To: Federico Vaga
Cc: Prabhakar Lad, LMML, dlos, Mauro Carvalho Chehab,
Laurent Pinchart, Hadli Manjunath
On Fri June 22 2012 18:53:27 Federico Vaga wrote:
> In data venerdì 22 giugno 2012 18:45:31, Hans Verkuil ha scritto:
> > On Fri June 22 2012 17:28:04 Federico Vaga wrote:
> > > > from commit a8f3c203e19b702fa5e8e83a9b6fb3c5a6d1cce4
> > > > restore the mapping scheme for uncached buffers,
> > > > which was changed in a common scheme for cached and uncached.
> > > > This apparently was wrong, and was probably intended only for
> > > > cached
> > > > buffers. the fix fixes the crash observed while mapping uncached
> > > > buffers.
> > > >
> > > > Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> > > > Signed-off-by: Hadli, Manjunath <manjunath.hadli@ti.com>
> > >
> > > Acked-by: Federico Vaga <federico.vaga@gmail.com>
> > >
> > > I tested the patch on the STA2X11 board.
> >
> > Was this patch ever posted on linux-media? I didn't see it on the
> > mailinglist, nor in my personal inbox.
> >
> > Perhaps something went wrong?
>
> I recived the email as CC and linux-media was the main destination.
> Davinci list was also added as CC and you can find the patch there:
>
> http://www.mail-archive.com/davinci-linux-open-
> source@linux.davincidsp.com/msg22998.html
>
> Something went wrong.
Weird, it never ended up at the linux-media mailinglist (not just me, it's
not in the linux-media archives either).
Anyway, I'll test this on Monday and if it works fine for me as well I'll Ack it.
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] [media] videobuf-dma-contig: restore buffer mapping for uncached bufers
2012-06-23 9:19 ` Hans Verkuil
@ 2012-06-25 11:43 ` Hans Verkuil
2012-06-25 11:56 ` Lad, Prabhakar
0 siblings, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2012-06-25 11:43 UTC (permalink / raw)
To: Prabhakar Lad
Cc: Federico Vaga, LMML, dlos, Mauro Carvalho Chehab,
Laurent Pinchart, Hadli Manjunath
On Sat 23 June 2012 11:19:24 Hans Verkuil wrote:
> On Fri June 22 2012 18:53:27 Federico Vaga wrote:
> > In data venerdì 22 giugno 2012 18:45:31, Hans Verkuil ha scritto:
> > > On Fri June 22 2012 17:28:04 Federico Vaga wrote:
> > > > > from commit a8f3c203e19b702fa5e8e83a9b6fb3c5a6d1cce4
> > > > > restore the mapping scheme for uncached buffers,
> > > > > which was changed in a common scheme for cached and uncached.
> > > > > This apparently was wrong, and was probably intended only for
> > > > > cached
> > > > > buffers. the fix fixes the crash observed while mapping uncached
> > > > > buffers.
> > > > >
> > > > > Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> > > > > Signed-off-by: Hadli, Manjunath <manjunath.hadli@ti.com>
> > > >
> > > > Acked-by: Federico Vaga <federico.vaga@gmail.com>
> > > >
> > > > I tested the patch on the STA2X11 board.
> > >
> > > Was this patch ever posted on linux-media? I didn't see it on the
> > > mailinglist, nor in my personal inbox.
> > >
> > > Perhaps something went wrong?
> >
> > I recived the email as CC and linux-media was the main destination.
> > Davinci list was also added as CC and you can find the patch there:
> >
> > http://www.mail-archive.com/davinci-linux-open-
> > source@linux.davincidsp.com/msg22998.html
> >
> > Something went wrong.
>
> Weird, it never ended up at the linux-media mailinglist (not just me, it's
> not in the linux-media archives either).
>
> Anyway, I'll test this on Monday and if it works fine for me as well I'll Ack it.
I've tested this patch, and it looks good:
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Prabhakar: Please post this again with all acks and marked as [PATCH for v3.5] to the
linux-media mailinglist asap. This patch never made it to this list for some reason,
so make sure it gets there this time.
Regards,
Hans
>
> Regards,
>
> Hans
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] [media] videobuf-dma-contig: restore buffer mapping for uncached bufers
2012-06-25 11:43 ` Hans Verkuil
@ 2012-06-25 11:56 ` Lad, Prabhakar
0 siblings, 0 replies; 6+ messages in thread
From: Lad, Prabhakar @ 2012-06-25 11:56 UTC (permalink / raw)
To: Hans Verkuil
Cc: Federico Vaga, LMML, dlos, Mauro Carvalho Chehab,
Laurent Pinchart, Hadli, Manjunath
Hi Hans,
On Mon, Jun 25, 2012 at 17:13:39, Hans Verkuil wrote:
> On Sat 23 June 2012 11:19:24 Hans Verkuil wrote:
> > On Fri June 22 2012 18:53:27 Federico Vaga wrote:
> > > In data venerdì 22 giugno 2012 18:45:31, Hans Verkuil ha scritto:
> > > > On Fri June 22 2012 17:28:04 Federico Vaga wrote:
> > > > > > from commit a8f3c203e19b702fa5e8e83a9b6fb3c5a6d1cce4
> > > > > > restore the mapping scheme for uncached buffers,
> > > > > > which was changed in a common scheme for cached and uncached.
> > > > > > This apparently was wrong, and was probably intended only for
> > > > > > cached
> > > > > > buffers. the fix fixes the crash observed while mapping uncached
> > > > > > buffers.
> > > > > >
> > > > > > Signed-off-by: Lad, Prabhakar <prabhakar.lad@ti.com>
> > > > > > Signed-off-by: Hadli, Manjunath <manjunath.hadli@ti.com>
> > > > >
> > > > > Acked-by: Federico Vaga <federico.vaga@gmail.com>
> > > > >
> > > > > I tested the patch on the STA2X11 board.
> > > >
> > > > Was this patch ever posted on linux-media? I didn't see it on the
> > > > mailinglist, nor in my personal inbox.
> > > >
> > > > Perhaps something went wrong?
> > >
> > > I recived the email as CC and linux-media was the main destination.
> > > Davinci list was also added as CC and you can find the patch there:
> > >
> > > http://www.mail-archive.com/davinci-linux-open-
> > > source@linux.davincidsp.com/msg22998.html
> > >
> > > Something went wrong.
> >
> > Weird, it never ended up at the linux-media mailinglist (not just me, it's
> > not in the linux-media archives either).
> >
> > Anyway, I'll test this on Monday and if it works fine for me as well I'll Ack it.
>
> I've tested this patch, and it looks good:
>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> Prabhakar: Please post this again with all acks and marked as [PATCH for v3.5] to the
> linux-media mailinglist asap. This patch never made it to this list for some reason,
> so make sure it gets there this time.
>
Ok. Thanks for the review.
Thx,
--Prabhakar Lad
> Regards,
>
> Hans
>
> >
> > Regards,
> >
> > Hans
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-25 11:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1340360046-23429-1-git-send-email-prabhakar.lad@ti.com>
2012-06-22 15:28 ` [PATCH] [media] videobuf-dma-contig: restore buffer mapping for uncached bufers Federico Vaga
2012-06-22 16:45 ` Hans Verkuil
2012-06-22 16:53 ` Federico Vaga
2012-06-23 9:19 ` Hans Verkuil
2012-06-25 11:43 ` Hans Verkuil
2012-06-25 11:56 ` Lad, Prabhakar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.