From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Bastian Hecht <hechtb@gmail.com>,
linux-sh@vger.kernel.org, linux-input@vger.kernel.org,
Tony SIM <chinyeow.sim.xt@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v2 1/2] input: st1232: Add reset pin handling
Date: Wed, 10 Apr 2013 11:11:27 +0200 [thread overview]
Message-ID: <3156128.fKWFDgdS29@avalon> (raw)
In-Reply-To: <20130410065114.GA21515@core.coreip.homeip.net>
Hi Dmitry,
On Tuesday 09 April 2013 23:51:14 Dmitry Torokhov wrote:
> On Mon, Apr 08, 2013 at 02:52:26PM +0200, Bastian Hecht wrote:
[snip]
> > + error = devm_gpio_request(&client->dev, ts->reset_gpio, NULL);
>
> Frankly I do not like mixing managed and noon-managed resources. Maybe
> the entire driver needs to be converted to managed resources?
I've just sent a patch to do so.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Bastian Hecht <hechtb@gmail.com>,
linux-sh@vger.kernel.org, linux-input@vger.kernel.org,
Tony SIM <chinyeow.sim.xt@renesas.com>,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH v2 1/2] input: st1232: Add reset pin handling
Date: Wed, 10 Apr 2013 09:11:27 +0000 [thread overview]
Message-ID: <3156128.fKWFDgdS29@avalon> (raw)
In-Reply-To: <20130410065114.GA21515@core.coreip.homeip.net>
Hi Dmitry,
On Tuesday 09 April 2013 23:51:14 Dmitry Torokhov wrote:
> On Mon, Apr 08, 2013 at 02:52:26PM +0200, Bastian Hecht wrote:
[snip]
> > + error = devm_gpio_request(&client->dev, ts->reset_gpio, NULL);
>
> Frankly I do not like mixing managed and noon-managed resources. Maybe
> the entire driver needs to be converted to managed resources?
I've just sent a patch to do so.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-04-10 9:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 12:52 [PATCH v2 1/2] input: st1232: Add reset pin handling Bastian Hecht
2013-04-08 12:52 ` Bastian Hecht
2013-04-08 12:52 ` [PATCH v2 2/2] ARM: shmobile: Armadillo800EVA: Move st1232 " Bastian Hecht
2013-04-08 12:52 ` Bastian Hecht
2013-04-08 14:17 ` Laurent Pinchart
2013-04-08 14:17 ` Laurent Pinchart
2013-04-09 8:26 ` Simon Horman
2013-04-09 8:26 ` Simon Horman
2013-04-09 9:11 ` Simon Horman
2013-04-09 9:11 ` Simon Horman
2013-04-09 9:16 ` Bastian Hecht
2013-04-09 9:16 ` Bastian Hecht
2013-04-09 11:55 ` Simon Horman
2013-04-09 11:55 ` Simon Horman
2013-04-09 15:01 ` Simon Horman
2013-04-09 15:01 ` Simon Horman
2013-04-09 15:04 ` Bastian Hecht
2013-04-09 15:04 ` Bastian Hecht
2014-04-25 16:18 ` [PATCH v2 2/2] ARM: shmobile: armadillo800eva defconfig: Enable REGULATOR_GPIO and LEDS_GPIO Geert Uytterhoeven
2013-04-08 14:17 ` [PATCH v2 1/2] input: st1232: Add reset pin handling Laurent Pinchart
2013-04-08 14:17 ` Laurent Pinchart
2013-04-09 8:28 ` Simon Horman
2013-04-09 8:28 ` Simon Horman
2013-04-09 9:23 ` Bastian Hecht
2013-04-09 9:23 ` Bastian Hecht
2013-04-09 15:01 ` Simon Horman
2013-04-09 15:01 ` Simon Horman
2013-04-10 6:51 ` Dmitry Torokhov
2013-04-10 6:51 ` Dmitry Torokhov
2013-04-10 7:25 ` Simon Horman
2013-04-10 7:25 ` Simon Horman
2013-04-10 6:51 ` Dmitry Torokhov
2013-04-10 6:51 ` Dmitry Torokhov
2013-04-10 9:11 ` Laurent Pinchart [this message]
2013-04-10 9:11 ` Laurent Pinchart
2013-04-10 21:38 ` Bastian Hecht
2013-04-10 21:38 ` Bastian Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3156128.fKWFDgdS29@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=chinyeow.sim.xt@renesas.com \
--cc=dmitry.torokhov@gmail.com \
--cc=hechtb@gmail.com \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.