All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Douglas Anderson <dianders@chromium.org>
Cc: linux-rockchip@lists.infradead.org, mturquette@baylibre.com,
	sboyd@codeaurora.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: rockchip: Remove useless init of "grf" to -EPROBE_DEFER
Date: Fri, 06 Jan 2017 20:32:02 +0100	[thread overview]
Message-ID: <3165407.VSLAtN8Q2L@phil> (raw)
In-Reply-To: <20170106163101.32048-1-dianders@chromium.org>

Am Freitag, 6. Januar 2017, 08:31:01 CET schrieb Douglas Anderson:
> When we used to defer setting the "grf" member to
> rockchip_clk_get_grf() it was important to init the "grf" member to an
> error value in rockchip_clk_init().  With recent changes, we now set
> "grf" right in rockchip_clk_init() (two lines below the place where we
> initted it).  That makes the old init useless.  Get rid of it.
> 
> Fixes: 6f339dc2719e ("clk: rockchip: lookup General Register Files in
> rockchip_clk_init") Signed-off-by: Douglas Anderson <dianders@chromium.org>

thanks for the catch, applied for 4.11


Thanks
Heiko

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: rockchip: Remove useless init of "grf" to -EPROBE_DEFER
Date: Fri, 06 Jan 2017 20:32:02 +0100	[thread overview]
Message-ID: <3165407.VSLAtN8Q2L@phil> (raw)
In-Reply-To: <20170106163101.32048-1-dianders@chromium.org>

Am Freitag, 6. Januar 2017, 08:31:01 CET schrieb Douglas Anderson:
> When we used to defer setting the "grf" member to
> rockchip_clk_get_grf() it was important to init the "grf" member to an
> error value in rockchip_clk_init().  With recent changes, we now set
> "grf" right in rockchip_clk_init() (two lines below the place where we
> initted it).  That makes the old init useless.  Get rid of it.
> 
> Fixes: 6f339dc2719e ("clk: rockchip: lookup General Register Files in
> rockchip_clk_init") Signed-off-by: Douglas Anderson <dianders@chromium.org>

thanks for the catch, applied for 4.11


Thanks
Heiko

  reply	other threads:[~2017-01-06 19:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 16:31 [PATCH] clk: rockchip: Remove useless init of "grf" to -EPROBE_DEFER Douglas Anderson
2017-01-06 16:31 ` Douglas Anderson
2017-01-06 19:32 ` Heiko Stuebner [this message]
2017-01-06 19:32   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3165407.VSLAtN8Q2L@phil \
    --to=heiko@sntech.de \
    --cc=dianders@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.