From: David Howells <dhowells@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "John Anthony Kazos Jr." <jakj@j-a-k-j.com>,
David Woodhouse <dwmw2@infradead.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Satyam Sharma <satyam.sharma@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Roland McGrath <roland@redhat.com>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: condingstyle, was Re: utrace comments
Date: Wed, 02 May 2007 13:05:34 +0100 [thread overview]
Message-ID: <31688.1178107534@redhat.com> (raw)
In-Reply-To: <m1fy6fxwx5.fsf@ebiederm.dsl.xmission.com>
Eric W. Biederman <ebiederm@xmission.com> wrote:
> > But the condition doesn't line up with the code:
>
> Exactly. The condition not lining up with the following code helps
> code helps separate the two.
Sorry about that: I realised you were agreeing with me about 5s after I sent
the message.
> However there is the practical way to solve this if you have
> a sufficiently large conditional, or the conditional appears
> several times.
That doesn't necessarily work - for instance if the condition has side effects
on local variables (eg: postinc). OTOH, large complex conditions with side
effects have to be abused with care and preferably avoided. goto is your
friend:-)
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: "John Anthony Kazos Jr." <jakj@j-a-k-j.com>,
David Woodhouse <dwmw2@infradead.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Satyam Sharma <satyam.sharma@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Roland McGrath <roland@redhat.com>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: condingstyle, was Re: utrace comments
Date: Wed, 02 May 2007 13:05:34 +0100 [thread overview]
Message-ID: <31688.1178107534@redhat.com> (raw)
In-Reply-To: <m1fy6fxwx5.fsf@ebiederm.dsl.xmission.com>
Eric W. Biederman <ebiederm@xmission.com> wrote:
> > But the condition doesn't line up with the code:
>
> Exactly. The condition not lining up with the following code helps
> code helps separate the two.
Sorry about that: I realised you were agreeing with me about 5s after I sent
the message.
> However there is the practical way to solve this if you have
> a sufficiently large conditional, or the conditional appears
> several times.
That doesn't necessarily work - for instance if the condition has side effects
on local variables (eg: postinc). OTOH, large complex conditions with side
effects have to be abused with care and preferably avoided. goto is your
friend:-)
David
next prev parent reply other threads:[~2007-05-02 12:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-27 16:51 utrace comments Christoph Hellwig
2006-12-05 9:51 ` Roland McGrath
2006-12-06 21:58 ` Christoph Hellwig
2007-04-30 4:02 ` Roland McGrath
2007-04-30 9:08 ` Christoph Hellwig
2007-04-30 9:18 ` Russell King
2007-04-30 9:22 ` Christoph Hellwig
2007-04-30 9:33 ` Russell King
2007-04-30 9:45 ` Russell King
2007-04-30 10:32 ` Christoph Hellwig
2007-04-30 10:18 ` Christoph Hellwig
2007-06-22 2:40 ` Roland McGrath
2007-05-10 8:49 ` Roland McGrath
2007-04-30 9:11 ` condingstyle, was " Christoph Hellwig
2007-04-30 17:09 ` Andrew Morton
2007-04-30 18:19 ` Jan Engelhardt
2007-04-30 18:39 ` Daniel Hazelton
2007-04-30 18:42 ` Satyam Sharma
2007-04-30 22:18 ` Stefan Richter
2007-05-01 9:00 ` Geert Uytterhoeven
2007-05-01 13:11 ` Scott Preece
2007-05-01 14:16 ` David Woodhouse
2007-05-01 15:00 ` John Anthony Kazos Jr.
2007-05-01 16:07 ` David Howells
2007-05-02 2:18 ` Eric W. Biederman
2007-05-02 9:32 ` David Howells
2007-05-02 9:32 ` David Howells
2007-05-02 11:55 ` Eric W. Biederman
2007-05-02 12:05 ` David Howells [this message]
2007-05-02 12:05 ` David Howells
2007-05-01 20:12 ` Satyam Sharma
2007-05-01 15:05 ` Randy Dunlap
2007-05-01 15:06 ` David Woodhouse
2007-05-01 20:44 ` Satyam Sharma
2007-05-01 15:07 ` Geert Uytterhoeven
2007-05-01 15:11 ` David Woodhouse
2007-05-01 16:15 ` Stuart MacDonald
2007-05-01 16:15 ` Stuart MacDonald
2007-04-30 21:34 ` Luck, Tony
2007-04-30 21:34 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31688.1178107534@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=ebiederm@xmission.com \
--cc=geert@linux-m68k.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jakj@j-a-k-j.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=satyam.sharma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.