All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Ezequiel Garcia <ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
Cc: Enric Balletbo i Serra
	<enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Manivannan Sadhasivam
	<manivannan.sadhasivam-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] arm64: dts: rock960: Enable tsadc device
Date: Sat, 16 Feb 2019 21:34:16 +0100	[thread overview]
Message-ID: <3185590.aYss3V9hle@phil> (raw)
In-Reply-To: <aa2f376897ffb4fef02bd3e64812c8e1dbe4987a.camel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>

Am Samstag, 16. Februar 2019, 03:55:01 CET schrieb Ezequiel Garcia:
> On Sat, 2019-02-16 at 00:14 +0100, Heiko Stübner wrote:
> > Hi Ezequiel,
> > 
> > Am Freitag, 15. Februar 2019, 16:25:39 CET schrieb Ezequiel Garcia:
> > > Enable the thermal sensor. This device also provides
> > > temperature shutdown protection. The shutdown value is
> > > set at 110C, as tested by the vendor.
> > > 
> > > Signed-off-by: Ezequiel Garcia <ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
> > > ---
> > >  arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi index
> > > d64d5ac0804a..599c9752ed4d 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > @@ -634,3 +634,10 @@
> > >          mali-supply = <&vdd_gpu>;
> > >          status = "okay";
> > >  };
> > 
> > doesn't apply against my 5.1/dts64 branch and our rock960.dtsi
> > also does not have a mali node yet (especially also not one with
> > space-indentation ;-) ).
> > 
> > 
> 
> Sorry about that, it was based on your for-next branch,
> but a mali patch slipped through.

I've fixed that up now and applied the fixed version for 5.1.
I've also moved the &tsadc to the correct position - alphabetically
between sdmmc and uart0. Please keep sorting in mind for future
additions ;-) .


Thanks
Heiko

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	linux-rockchip@lists.infradead.org, kernel@collabora.com,
	linux-arm-kernel@lists.infradead.org,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH] arm64: dts: rock960: Enable tsadc device
Date: Sat, 16 Feb 2019 21:34:16 +0100	[thread overview]
Message-ID: <3185590.aYss3V9hle@phil> (raw)
In-Reply-To: <aa2f376897ffb4fef02bd3e64812c8e1dbe4987a.camel@collabora.com>

Am Samstag, 16. Februar 2019, 03:55:01 CET schrieb Ezequiel Garcia:
> On Sat, 2019-02-16 at 00:14 +0100, Heiko Stübner wrote:
> > Hi Ezequiel,
> > 
> > Am Freitag, 15. Februar 2019, 16:25:39 CET schrieb Ezequiel Garcia:
> > > Enable the thermal sensor. This device also provides
> > > temperature shutdown protection. The shutdown value is
> > > set at 110C, as tested by the vendor.
> > > 
> > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > > ---
> > >  arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi index
> > > d64d5ac0804a..599c9752ed4d 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > @@ -634,3 +634,10 @@
> > >          mali-supply = <&vdd_gpu>;
> > >          status = "okay";
> > >  };
> > 
> > doesn't apply against my 5.1/dts64 branch and our rock960.dtsi
> > also does not have a mali node yet (especially also not one with
> > space-indentation ;-) ).
> > 
> > 
> 
> Sorry about that, it was based on your for-next branch,
> but a mali patch slipped through.

I've fixed that up now and applied the fixed version for 5.1.
I've also moved the &tsadc to the correct position - alphabetically
between sdmmc and uart0. Please keep sorting in mind for future
additions ;-) .


Thanks
Heiko



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-02-16 20:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15 15:25 [PATCH] arm64: dts: rock960: Enable tsadc device Ezequiel Garcia
2019-02-15 15:25 ` Ezequiel Garcia
     [not found] ` <20190215152539.16606-1-ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-02-15 23:14   ` Heiko Stübner
2019-02-15 23:14     ` Heiko Stübner
2019-02-16  2:55     ` Ezequiel Garcia
     [not found]       ` <aa2f376897ffb4fef02bd3e64812c8e1dbe4987a.camel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2019-02-16 20:34         ` Heiko Stuebner [this message]
2019-02-16 20:34           ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3185590.aYss3V9hle@phil \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    --cc=ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    --cc=kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=manivannan.sadhasivam-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.