All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: Re: [PATCH] mldev: disable build on Windows
Date: Fri, 10 Mar 2023 10:18:32 +0100	[thread overview]
Message-ID: <3186427.AJdgDx1Vlc@thomas> (raw)
In-Reply-To: <20230310090717.1470032-1-david.marchand@redhat.com>

The build breaks because of the weak symbols, so we can define this cause:

Fixes: 9637de38a2e3 ("mldev: add scalar type conversion")


10/03/2023 10:07, David Marchand:
> --- a/lib/mldev/meson.build
> +++ b/lib/mldev/meson.build
> +if is_windows
> +    subdir_done()
> +endif

More complete handling:

if is_windows
    build = false
    reason = 'not supported on Windows'
    subdir_done()
endif




  reply	other threads:[~2023-03-10  9:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10  9:07 [PATCH] mldev: disable build on Windows David Marchand
2023-03-10  9:18 ` Thomas Monjalon [this message]
2023-03-10  9:19   ` David Marchand
2023-03-10  9:23 ` [PATCH v2] " David Marchand
2023-03-10  9:32   ` Thomas Monjalon
2023-03-10 20:06 ` [PATCH] " Tyler Retzlaff
2023-03-10 22:54   ` Stephen Hemminger
2023-03-11  8:11     ` Thomas Monjalon
2023-03-11 14:53       ` [EXT] " Srikanth Yalavarthi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3186427.AJdgDx1Vlc@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=syalavarthi@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.