From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, Srikanth Yalavarthi <syalavarthi@marvell.com>
Subject: Re: [PATCH] mldev: disable build on Windows
Date: Sat, 11 Mar 2023 09:11:35 +0100 [thread overview]
Message-ID: <4562733.CvnuH1ECHv@thomas> (raw)
In-Reply-To: <20230310145419.4ff5425e@hermes.local>
10/03/2023 23:54, Stephen Hemminger:
> On Fri, 10 Mar 2023 12:06:35 -0800
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
>
> > On Fri, Mar 10, 2023 at 10:07:17AM +0100, David Marchand wrote:
> > > Caught by UNH lab, Windows compilation is broken because of symbol
> > > exports:
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_bfloat16_to_float32
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float16_to_float32
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_bfloat16
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_float16
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_int16
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_int8
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_uint16
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_float32_to_uint8
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_int16_to_float32
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_int8_to_float32
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_uint16_to_float32
> > > rte_mldev_exports.def : error LNK2001: unresolved external symbol
> > > rte_ml_io_uint8_to_float32
> > >
> > > Disable Windows build until this is fixed.
> >
> > is someone committed to do this?
>
> This is not hard to fix, please fix the Windows build rather than disabling.
I think we may need to change how the NEON implementation is selected,
without using weak references.
Feel free to submit a patch.
next prev parent reply other threads:[~2023-03-11 8:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 9:07 [PATCH] mldev: disable build on Windows David Marchand
2023-03-10 9:18 ` Thomas Monjalon
2023-03-10 9:19 ` David Marchand
2023-03-10 9:23 ` [PATCH v2] " David Marchand
2023-03-10 9:32 ` Thomas Monjalon
2023-03-10 20:06 ` [PATCH] " Tyler Retzlaff
2023-03-10 22:54 ` Stephen Hemminger
2023-03-11 8:11 ` Thomas Monjalon [this message]
2023-03-11 14:53 ` [EXT] " Srikanth Yalavarthi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4562733.CvnuH1ECHv@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=stephen@networkplumber.org \
--cc=syalavarthi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.