From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: drm/bridge: adv7511: Add regulator bindings
Date: Tue, 06 Dec 2016 14:46:55 +0200 [thread overview]
Message-ID: <3208429.mJrxuV2Nx6@avalon> (raw)
In-Reply-To: <20161206100517.q2v73kj256kyhmlg@sirena.org.uk>
Hi Mark,
On Tuesday 06 Dec 2016 10:05:17 Mark Brown wrote:
> On Mon, Dec 05, 2016 at 11:16:22PM +0200, Laurent Pinchart wrote:
> > On Monday 05 Dec 2016 13:11:51 Bjorn Andersson wrote:
> >> Further more, a DT binding for a particular block should describe that
> >> block; so if we have three different 1.8V pins then the DT binding
> >> should reflect this - even if our current platform have them wired to
> >> the same regulator.
> >
> > This has been discussed previously, and Rob agreed that if the datasheet
> > recommends to power all supplies from the same regulator we can take that
> > as a good hint that a single supply should be enough. In the very
> > unlikely event that a board would require control of more regulators we
> > can always extend the DT bindings later without breaking backward
> > compatibility.
>
> No, don't do this - introducing special snowflake bindings just makes
> things more complex at the system level and tells everyone else that
> they too can have special snowflake bindings. Someone should be able to
> connect up the regulators based purely on a schematic. Just describe
> the hardware, it's just one extra line in the DT per regulator.
There are power supply pin that have different names but documented as having
to be connected to the same supply. I really see no point in having multiple
regulators for them.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-06 12:46 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 10:52 [PATCH 0/3] arm64: apq8016-sbc: Enable regulators for ADV7533 Archit Taneja
[not found] ` <1472640730-24326-1-git-send-email-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-31 10:52 ` [PATCH 1/3] dt-bindings: drm/bridge: adv7511: Add " Archit Taneja
2016-09-02 15:56 ` Rob Herring
2016-09-06 4:22 ` Archit Taneja
2016-08-31 10:52 ` [PATCH 2/3] drm/bridge: adv7533: Initialize regulators Archit Taneja
2016-08-31 15:53 ` Laurent Pinchart
2016-08-31 16:54 ` Archit Taneja
2016-08-31 20:30 ` Laurent Pinchart
2016-09-01 10:09 ` Archit Taneja
2016-08-31 10:52 ` [PATCH 3/3] arm64: dts: apq8016-sbc: Set up LDO2, LDO6 and LDO17 regulator voltage ranges Archit Taneja
2016-08-31 20:54 ` Stephen Boyd
2016-09-01 6:12 ` Archit Taneja
2016-09-02 3:47 ` Bjorn Andersson
2016-09-23 9:20 ` [PATCH v2 0/4] arm64: apq8016-sbc: Enable regulators for ADV7533 Archit Taneja
2016-09-23 9:20 ` [PATCH v2 1/4] dt-bindings: drm/bridge: adv7511: Add regulator bindings Archit Taneja
2016-09-23 22:31 ` Rob Herring
[not found] ` <1474622430-6704-2-git-send-email-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-09-25 17:28 ` Laurent Pinchart
2016-09-26 6:40 ` Archit Taneja
2016-09-26 8:12 ` Laurent Pinchart
2016-10-14 5:40 ` Archit Taneja
2016-11-10 1:34 ` Rob Herring
[not found] ` <CAL_Jsq+KMPoyWvh1U3OKL6pX8D4QByqVFgcMks8myDfZEYeFCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-15 3:35 ` Archit Taneja
2016-09-23 9:20 ` [PATCH v2 2/4] drm/bridge: adv7511: Initialize regulators Archit Taneja
2016-09-25 17:35 ` Laurent Pinchart
2016-09-26 6:40 ` Archit Taneja
2016-09-23 9:20 ` [PATCH v2 3/4] arm64: dts: apq8016-sbc: Add some missing regulator supplies for ADV7533 Archit Taneja
2016-09-23 9:20 ` [PATCH v2 4/4] arm64: dts: apq8016-sbc: Set up LDO2, LDO6 and LDO17 regulator voltage ranges Archit Taneja
2016-11-29 6:07 ` [PATCH v3 0/2] drm/bridge: adv7511: Enable regulators Archit Taneja
[not found] ` <1480399662-8858-1-git-send-email-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-11-29 6:07 ` [PATCH v3 1/2] dt-bindings: drm/bridge: adv7511: Add regulator bindings Archit Taneja
[not found] ` <1480399662-8858-2-git-send-email-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-11-29 6:33 ` Laurent Pinchart
2016-11-29 8:11 ` Archit Taneja
2016-11-29 9:11 ` Laurent Pinchart
2016-11-29 11:01 ` Mark Brown
2016-11-29 19:37 ` Laurent Pinchart
2016-11-30 16:14 ` Mark Brown
2016-12-05 21:11 ` Bjorn Andersson
2016-12-05 21:16 ` Laurent Pinchart
2016-12-06 10:05 ` Mark Brown
2016-12-06 12:46 ` Laurent Pinchart [this message]
2016-12-06 13:20 ` Mark Brown
2016-12-06 16:08 ` Laurent Pinchart
2016-12-06 16:11 ` Mark Brown
2016-11-29 6:07 ` [PATCH v3 2/2] drm/bridge: adv7511: Initialize regulators Archit Taneja
2016-11-29 6:28 ` Laurent Pinchart
2016-12-05 7:53 ` [PATCH v4 0/2] drm/bridge: adv7511: Enable regulators Archit Taneja
2016-12-05 7:53 ` [PATCH v4 1/2] dt-bindings: drm/bridge: adv7511: Add regulator bindings Archit Taneja
2016-12-09 22:11 ` Rob Herring
2016-12-18 11:17 ` Archit Taneja
2016-12-05 7:53 ` [PATCH v4 2/2] drm/bridge: adv7511: Initialize regulators Archit Taneja
2017-01-11 6:52 ` [PATCH v5 0/2] drm/bridge: adv7511: Enable regulators Archit Taneja
2017-01-11 6:52 ` [PATCH v5 1/2] dt-bindings: drm/bridge: adv7511: Add regulator bindings Archit Taneja
2017-01-11 6:52 ` [PATCH v5 2/2] drm/bridge: adv7511: Initialize regulators Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3208429.mJrxuV2Nx6@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.