All of lore.kernel.org
 help / color / mirror / Atom feed
From: George Dunlap <george.dunlap@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH 1/3] x86/mm: Use a more descriptive name for pagetable mfns
Date: Mon, 16 Dec 2019 11:10:12 +0000	[thread overview]
Message-ID: <320a5402-128d-a77c-ef5b-9a951d7cd4d2@citrix.com> (raw)
In-Reply-To: <ba4eb59e-ac37-6ec2-e699-d359f1565cf5@suse.com>

On 12/16/19 11:07 AM, Jan Beulich wrote:
> On 13.12.2019 18:37, George Dunlap wrote:
>> In many places, a PTE being modified is accompanied by the pagetable
>> mfn which contains the PTE (primarily in order to be able to maintain
>> linear mapping counts).  In many cases, this mfn is stored in the
>> non-descript variable (or argement) "pfn".
>>
>> Replace these names with lNmfn, to indicate that 1) this is a
>> pagetable mfn, and 2) that it is the same level as the PTE in
>> question.  This should be enough to remind readers that it's the mfn
>> containing the PTE.
>>
>> No functional change.
>>
>> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> I take it you considered by dropped the idea of switching to mfn_t
> at the same time, as suggested by Andrew on v1?

Me: <waits for Jan to get to patch 2>

:-)

I thought it would be easier to review as two patches, each of which did
exactly one thing.  Since this patch was already complete, it was just
as easy to make a second patch as to make one more-complicated-to-review
patch.

Thanks,
 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-12-16 11:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13 17:37 [Xen-devel] [PATCH 0/3] Post-299 cleanups George Dunlap
2019-12-13 17:37 ` [Xen-devel] [PATCH 1/3] x86/mm: Use a more descriptive name for pagetable mfns George Dunlap
2019-12-16 11:07   ` Jan Beulich
2019-12-16 11:10     ` George Dunlap [this message]
2019-12-13 17:37 ` [Xen-devel] [PATCH 2/3] x86/mm: Use mfn_t in type get / put call tree George Dunlap
2019-12-16 11:10   ` Jan Beulich
2019-12-16 11:13     ` George Dunlap
2019-12-16 11:25       ` Jan Beulich
2019-12-13 17:37 ` [Xen-devel] [PATCH 3/3] x86/mm: More discriptive names for page de/validation functions George Dunlap
2019-12-16 11:15   ` Jan Beulich
2019-12-16 13:24 ` [Xen-devel] [PATCH 0/3] Post-299 cleanups Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=320a5402-128d-a77c-ef5b-9a951d7cd4d2@citrix.com \
    --to=george.dunlap@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.