From: Jan Beulich <jbeulich@suse.com>
To: George Dunlap <george.dunlap@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH 3/3] x86/mm: More discriptive names for page de/validation functions
Date: Mon, 16 Dec 2019 12:15:19 +0100 [thread overview]
Message-ID: <609d2bb5-9b83-16be-f2c2-eacef344cd68@suse.com> (raw)
In-Reply-To: <20191213173742.1960441-4-george.dunlap@citrix.com>
On 13.12.2019 18:37, George Dunlap wrote:
> The functions alloc_page_type(), alloc_lN_table(), free_page_type()
> and free_lN_table() are confusingly named: nothing is being allocated
> or freed. Rather, the page being passed in is being either validated
> or devalidated for use as the specific type; in the specific case of
> pagetables, these may be promoted or demoted (i.e., grab appropriate
> references for PTEs).
>
> Rename alloc_page_type() and free_page_type() to validate_page() and
> devalidate_page(). Also rename alloc_segdesc_page() to
> validate_segdesc_page(), since this is what it's doing.
>
> Rename alloc_lN_table() and free_lN_table() to promote_lN_table() and
> demote_lN_table(), respectively.
>
> After this change:
> - get / put type consistenly refer to increasing or decreasing the count
> - validate / devalidate consistently refers to actions done when a
> type count goes 0 -> 1 or 1 -> 0
> - promote / demote consistenly refers to acquiring or freeing
> resources (in the form of type refs and general references) in order
> to allow a page to be used as a pagetable.
>
> No functional change.
>
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-16 11:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 17:37 [Xen-devel] [PATCH 0/3] Post-299 cleanups George Dunlap
2019-12-13 17:37 ` [Xen-devel] [PATCH 1/3] x86/mm: Use a more descriptive name for pagetable mfns George Dunlap
2019-12-16 11:07 ` Jan Beulich
2019-12-16 11:10 ` George Dunlap
2019-12-13 17:37 ` [Xen-devel] [PATCH 2/3] x86/mm: Use mfn_t in type get / put call tree George Dunlap
2019-12-16 11:10 ` Jan Beulich
2019-12-16 11:13 ` George Dunlap
2019-12-16 11:25 ` Jan Beulich
2019-12-13 17:37 ` [Xen-devel] [PATCH 3/3] x86/mm: More discriptive names for page de/validation functions George Dunlap
2019-12-16 11:15 ` Jan Beulich [this message]
2019-12-16 13:24 ` [Xen-devel] [PATCH 0/3] Post-299 cleanups Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=609d2bb5-9b83-16be-f2c2-eacef344cd68@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.