From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Yisheng Xie <ysxie@foxmail.com>
Cc: linux-fbdev@vger.kernel.org, j.w.r.degoede@gmail.com,
keescook@chromium.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
andriy.shevchenko@linux.intel.com, david@lechnology.com
Subject: Re: [PATCH v2 fbdev-for-next 1/2] fbcon: introduce for_each_registered_fb() helper
Date: Tue, 24 Jul 2018 15:18:30 +0000 [thread overview]
Message-ID: <3211840.FYfgcvebvD@amdc3058> (raw)
In-Reply-To: <1530343789-4237-1-git-send-email-ysxie@foxmail.com>
On Saturday, June 30, 2018 03:29:49 PM Yisheng Xie wrote:
> Following pattern is often used:
>
> for (i = 0; i < FB_MAX; i++) {
> if (registered_fb[i]) {
> ...
> }
> }
>
> Therefore, as Andy's suggestion, for_each_registered_fb() helper can
> be introduced to make the code easier to read and write by reducing
> indentation level. It also saves few lines of code in each occurrence.
>
> This patch convert all part here at the same time.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Yisheng Xie <ysxie@foxmail.com>
Patch queued for 4.19, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Yisheng Xie <ysxie@foxmail.com>
Cc: linux-fbdev@vger.kernel.org, j.w.r.degoede@gmail.com,
keescook@chromium.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
andriy.shevchenko@linux.intel.com, david@lechnology.com
Subject: Re: [PATCH v2 fbdev-for-next 1/2] fbcon: introduce for_each_registered_fb() helper
Date: Tue, 24 Jul 2018 17:18:30 +0200 [thread overview]
Message-ID: <3211840.FYfgcvebvD@amdc3058> (raw)
In-Reply-To: <1530343789-4237-1-git-send-email-ysxie@foxmail.com>
On Saturday, June 30, 2018 03:29:49 PM Yisheng Xie wrote:
> Following pattern is often used:
>
> for (i = 0; i < FB_MAX; i++) {
> if (registered_fb[i]) {
> ...
> }
> }
>
> Therefore, as Andy's suggestion, for_each_registered_fb() helper can
> be introduced to make the code easier to read and write by reducing
> indentation level. It also saves few lines of code in each occurrence.
>
> This patch convert all part here at the same time.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Yisheng Xie <ysxie@foxmail.com>
Patch queued for 4.19, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Yisheng Xie <ysxie@foxmail.com>
Cc: keescook@chromium.org, j.w.r.degoede@gmail.com,
david@lechnology.com, andriy.shevchenko@linux.intel.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 fbdev-for-next 1/2] fbcon: introduce for_each_registered_fb() helper
Date: Tue, 24 Jul 2018 17:18:30 +0200 [thread overview]
Message-ID: <3211840.FYfgcvebvD@amdc3058> (raw)
In-Reply-To: <1530343789-4237-1-git-send-email-ysxie@foxmail.com>
On Saturday, June 30, 2018 03:29:49 PM Yisheng Xie wrote:
> Following pattern is often used:
>
> for (i = 0; i < FB_MAX; i++) {
> if (registered_fb[i]) {
> ...
> }
> }
>
> Therefore, as Andy's suggestion, for_each_registered_fb() helper can
> be introduced to make the code easier to read and write by reducing
> indentation level. It also saves few lines of code in each occurrence.
>
> This patch convert all part here at the same time.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Yisheng Xie <ysxie@foxmail.com>
Patch queued for 4.19, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
next prev parent reply other threads:[~2018-07-24 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180630073004epcas2p2d87aa0abbbae08dafd661c8378ba1de1@epcas2p2.samsung.com>
2018-06-30 7:29 ` [PATCH v2 fbdev-for-next 1/2] fbcon: introduce for_each_registered_fb() helper Yisheng Xie
2018-06-30 7:29 ` Yisheng Xie
2018-06-30 10:32 ` Hans de Goede
2018-06-30 10:32 ` Hans de Goede
2018-06-30 15:50 ` Andy Shevchenko
2018-06-30 15:50 ` Andy Shevchenko
2018-07-02 13:57 ` Jani Nikula
2018-07-02 13:57 ` Jani Nikula
2018-07-02 13:57 ` Jani Nikula
2018-07-24 15:18 ` Bartlomiej Zolnierkiewicz [this message]
2018-07-24 15:18 ` Bartlomiej Zolnierkiewicz
2018-07-24 15:18 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3211840.FYfgcvebvD@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=david@lechnology.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=j.w.r.degoede@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ysxie@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.