From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dwmw2@infradead.org, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
uclinux-dev@uclinux.org
Subject: Re: [PATCH 4/4] NOMMU: Make it possible for RomFS to use MTD devices directly
Date: Thu, 22 Feb 2007 11:43:00 +0000 [thread overview]
Message-ID: <32148.1172144580@redhat.com> (raw)
In-Reply-To: <20070221163839.b4f5e3b5.akpm@linux-foundation.org>
Andrew Morton <akpm@linux-foundation.org> wrote:
> > + brelse(bh);
>
> A little fyi: brelse() is rather old-fashioned, and has a usually unneeded
> test for non-null bh in it. In situations where we know that the pointer is
> valid, let's please use put_bh().
That's what was in the old romfs. I can make the change, though.
Hmmm... brelse() isn't quite equivalent to put_bh(), but the difference seems
just to be the message you get if you over-release a buffer head - and the
resulting refcount on the BH if that happens.
> Anyway, I'll assume that dwmw2 will be handling this patch series.
I assume so.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: torvalds@linux-foundation.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 4/4] NOMMU: Make it possible for RomFS to use MTD devices directly
Date: Thu, 22 Feb 2007 11:43:00 +0000 [thread overview]
Message-ID: <32148.1172144580@redhat.com> (raw)
In-Reply-To: <20070221163839.b4f5e3b5.akpm@linux-foundation.org>
Andrew Morton <akpm@linux-foundation.org> wrote:
> > + brelse(bh);
>
> A little fyi: brelse() is rather old-fashioned, and has a usually unneeded
> test for non-null bh in it. In situations where we know that the pointer is
> valid, let's please use put_bh().
That's what was in the old romfs. I can make the change, though.
Hmmm... brelse() isn't quite equivalent to put_bh(), but the difference seems
just to be the message you get if you over-release a buffer head - and the
resulting refcount on the BH if that happens.
> Anyway, I'll assume that dwmw2 will be handling this patch series.
I assume so.
David
next prev parent reply other threads:[~2007-02-22 11:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 19:50 [PATCH 1/4] NOMMU: Present backing device capabilities for MTD chardevs David Howells
2007-02-20 19:50 ` [PATCH 2/4] NOMMU: Add support for direct mapping through mtdconcat if possible David Howells
2007-02-20 19:51 ` [PATCH 3/4] NOMMU: Generalise the handling of MTD-specific superblocks David Howells
2007-02-20 19:51 ` [PATCH 4/4] NOMMU: Make it possible for RomFS to use MTD devices directly David Howells
2007-02-22 0:38 ` Andrew Morton
2007-02-22 0:38 ` Andrew Morton
2007-02-22 11:43 ` David Howells [this message]
2007-02-22 11:43 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2007-02-21 12:56 [PATCH 1/4] NOMMU: Present backing device capabilities for MTD chardevs David Howells
2007-02-21 12:56 ` [PATCH 4/4] NOMMU: Make it possible for RomFS to use MTD devices directly David Howells
2007-02-21 12:56 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32148.1172144580@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.