From: Heiko Stuebner <heiko@sntech.de>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Michael Riesch <michael.riesch@wolfvision.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liang Chen <cl@rock-chips.com>, Peter Geis <pgwipeout@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x
Date: Sat, 30 Apr 2022 16:07:25 +0200 [thread overview]
Message-ID: <3229434.5fSG56mABF@phil> (raw)
In-Reply-To: <ca670161-7133-631e-f4b6-b48c8fde669b@wolfvision.net>
Am Donnerstag, 28. April 2022, 15:24:09 CEST schrieb Michael Riesch:
> Hi Nicolas,
>
> On 4/28/22 13:15, Nicolas Frattaroli wrote:
> > On Montag, 25. April 2022 15:35:00 CEST Michael Riesch wrote:
> >> This USB 3.0 controller is capable of OTG/DRD operation. Enable it in the
> >> device tree.
> >>
> >> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> >> ---
> >> arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> >> index 55e6dcb948cc..f611aaf2d238 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> >> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> >> @@ -266,7 +266,7 @@ usb_host0_xhci: usb@fcc00000 {
> >> <&cru ACLK_USB3OTG0>;
> >> clock-names = "ref_clk", "suspend_clk",
> >> "bus_clk";
> >> - dr_mode = "host";
> >> + dr_mode = "otg";
> >> phy_type = "utmi_wide";
> >> power-domains = <&power RK3568_PD_PIPE>;
> >> resets = <&cru SRST_USB3OTG0>;
> >>
> >
> > Hi Michael,
> >
> > according to official specs[1], only the RK3568 is capable of using the
> > USB 3.0 controller in OTG mode. For the RK3566, OTG is USB 2.0, if I
> > understand this correctly.
> >
> > So I think this should be an override in rk3568.dtsi.
>
> Thanks for pointing that out -- will change in v2 (I'll wait a bit,
> though, as I hope that patches 2 and 3 will be applied as they are ;-)
that can be arranged ;-)
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Michael Riesch <michael.riesch@wolfvision.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liang Chen <cl@rock-chips.com>, Peter Geis <pgwipeout@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x
Date: Sat, 30 Apr 2022 16:07:25 +0200 [thread overview]
Message-ID: <3229434.5fSG56mABF@phil> (raw)
In-Reply-To: <ca670161-7133-631e-f4b6-b48c8fde669b@wolfvision.net>
Am Donnerstag, 28. April 2022, 15:24:09 CEST schrieb Michael Riesch:
> Hi Nicolas,
>
> On 4/28/22 13:15, Nicolas Frattaroli wrote:
> > On Montag, 25. April 2022 15:35:00 CEST Michael Riesch wrote:
> >> This USB 3.0 controller is capable of OTG/DRD operation. Enable it in the
> >> device tree.
> >>
> >> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> >> ---
> >> arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> >> index 55e6dcb948cc..f611aaf2d238 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> >> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> >> @@ -266,7 +266,7 @@ usb_host0_xhci: usb@fcc00000 {
> >> <&cru ACLK_USB3OTG0>;
> >> clock-names = "ref_clk", "suspend_clk",
> >> "bus_clk";
> >> - dr_mode = "host";
> >> + dr_mode = "otg";
> >> phy_type = "utmi_wide";
> >> power-domains = <&power RK3568_PD_PIPE>;
> >> resets = <&cru SRST_USB3OTG0>;
> >>
> >
> > Hi Michael,
> >
> > according to official specs[1], only the RK3568 is capable of using the
> > USB 3.0 controller in OTG mode. For the RK3566, OTG is USB 2.0, if I
> > understand this correctly.
> >
> > So I think this should be an override in rk3568.dtsi.
>
> Thanks for pointing that out -- will change in v2 (I'll wait a bit,
> though, as I hope that patches 2 and 3 will be applied as they are ;-)
that can be arranged ;-)
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Michael Riesch <michael.riesch@wolfvision.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liang Chen <cl@rock-chips.com>, Peter Geis <pgwipeout@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x
Date: Sat, 30 Apr 2022 16:07:25 +0200 [thread overview]
Message-ID: <3229434.5fSG56mABF@phil> (raw)
In-Reply-To: <ca670161-7133-631e-f4b6-b48c8fde669b@wolfvision.net>
Am Donnerstag, 28. April 2022, 15:24:09 CEST schrieb Michael Riesch:
> Hi Nicolas,
>
> On 4/28/22 13:15, Nicolas Frattaroli wrote:
> > On Montag, 25. April 2022 15:35:00 CEST Michael Riesch wrote:
> >> This USB 3.0 controller is capable of OTG/DRD operation. Enable it in the
> >> device tree.
> >>
> >> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> >> ---
> >> arch/arm64/boot/dts/rockchip/rk356x.dtsi | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> >> index 55e6dcb948cc..f611aaf2d238 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> >> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> >> @@ -266,7 +266,7 @@ usb_host0_xhci: usb@fcc00000 {
> >> <&cru ACLK_USB3OTG0>;
> >> clock-names = "ref_clk", "suspend_clk",
> >> "bus_clk";
> >> - dr_mode = "host";
> >> + dr_mode = "otg";
> >> phy_type = "utmi_wide";
> >> power-domains = <&power RK3568_PD_PIPE>;
> >> resets = <&cru SRST_USB3OTG0>;
> >>
> >
> > Hi Michael,
> >
> > according to official specs[1], only the RK3568 is capable of using the
> > USB 3.0 controller in OTG mode. For the RK3566, OTG is USB 2.0, if I
> > understand this correctly.
> >
> > So I think this should be an override in rk3568.dtsi.
>
> Thanks for pointing that out -- will change in v2 (I'll wait a bit,
> though, as I hope that patches 2 and 3 will be applied as they are ;-)
that can be arranged ;-)
Heiko
next prev parent reply other threads:[~2022-04-30 14:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 13:35 [PATCH 1/3] arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x Michael Riesch
2022-04-25 13:35 ` Michael Riesch
2022-04-25 13:35 ` Michael Riesch
2022-04-25 13:35 ` [PATCH 2/3] arm64: dts: rockchip: add usb3 support to the radxa rock3 model a Michael Riesch
2022-04-25 13:35 ` Michael Riesch
2022-04-25 13:35 ` Michael Riesch
2022-04-25 13:35 ` [PATCH 3/3] arm64: dts: rockchip: enable usb hub on " Michael Riesch
2022-04-25 13:35 ` Michael Riesch
2022-04-25 13:35 ` Michael Riesch
2022-04-28 11:15 ` [PATCH 1/3] arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk356x Nicolas Frattaroli
2022-04-28 11:15 ` Nicolas Frattaroli
2022-04-28 11:15 ` Nicolas Frattaroli
2022-04-28 13:24 ` Michael Riesch
2022-04-28 13:24 ` Michael Riesch
2022-04-28 13:24 ` Michael Riesch
2022-04-30 14:07 ` Heiko Stuebner [this message]
2022-04-30 14:07 ` Heiko Stuebner
2022-04-30 14:07 ` Heiko Stuebner
2022-05-02 11:22 ` Michael Riesch
2022-05-02 11:22 ` Michael Riesch
2022-05-02 11:22 ` Michael Riesch
2022-04-30 14:05 ` (subset) " Heiko Stuebner
2022-04-30 14:05 ` Heiko Stuebner
2022-04-30 14:05 ` Heiko Stuebner
2022-05-11 4:14 ` Heiko Stuebner
2022-05-11 4:14 ` Heiko Stuebner
2022-05-11 4:14 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3229434.5fSG56mABF@phil \
--to=heiko@sntech.de \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=frattaroli.nicolas@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.