All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Andrew Lunn <andrew@lunn.ch>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org,
	Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 6/6] net: stmmac: rk: rk3506, rk3528 and rk3588 have rmii_mode in clock register
Date: Wed, 04 Feb 2026 22:54:58 +0100	[thread overview]
Message-ID: <3238497.eGJsNajkDb@diego> (raw)
In-Reply-To: <E1vnYyB-00000007hpF-1dwK@rmk-PC.armlinux.org.uk>

Am Mittwoch, 4. Februar 2026, 10:14:43 Mitteleuropäische Normalzeit schrieb Russell King (Oracle):
> rk3506, rk3528 and rk3588 have the rmii_mode bit in the clock GRF
> register rather than the gmac GRF register. Provide a mask for this
> field in the clock register, and convert these SoCs to use this.
> Add the necessary code in rk_gmac_powerup() to write this field.
> 
> This allows us to get rid of these SoCs set_to_rmii() function. As
> such, we need to mark these SoCs as supporting RMII mode.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de> #px30,rk3328,rk3568,rk3588





WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Andrew Lunn <andrew@lunn.ch>,
	"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org,
	Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 6/6] net: stmmac: rk: rk3506, rk3528 and rk3588 have rmii_mode in clock register
Date: Wed, 04 Feb 2026 22:54:58 +0100	[thread overview]
Message-ID: <3238497.eGJsNajkDb@diego> (raw)
In-Reply-To: <E1vnYyB-00000007hpF-1dwK@rmk-PC.armlinux.org.uk>

Am Mittwoch, 4. Februar 2026, 10:14:43 Mitteleuropäische Normalzeit schrieb Russell King (Oracle):
> rk3506, rk3528 and rk3588 have the rmii_mode bit in the clock GRF
> register rather than the gmac GRF register. Provide a mask for this
> field in the clock register, and convert these SoCs to use this.
> Add the necessary code in rk_gmac_powerup() to write this field.
> 
> This allows us to get rid of these SoCs set_to_rmii() function. As
> such, we need to mark these SoCs as supporting RMII mode.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Heiko Stuebner <heiko@sntech.de> #px30,rk3328,rk3568,rk3588




_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2026-02-04 21:55 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04  9:14 [PATCH net-next 0/6] net: stmmac: rk: final cleanups part Russell King (Oracle)
2026-02-04  9:14 ` Russell King (Oracle)
2026-02-04  9:14 ` [PATCH net-next 1/6] net: stmmac: rk: introduce flags indicating support for RGMII/RMII Russell King (Oracle)
2026-02-04  9:14   ` Russell King (Oracle)
2026-02-04  9:39   ` Maxime Chevallier
2026-02-04  9:39     ` Maxime Chevallier
2026-02-04 19:57   ` Heiko Stübner
2026-02-04 19:57     ` Heiko Stübner
2026-02-04  9:14 ` [PATCH net-next 2/6] net: stmmac: rk: replace empty set_to_rmii() with supports_rmii Russell King (Oracle)
2026-02-04  9:14   ` Russell King (Oracle)
2026-02-04  9:40   ` Maxime Chevallier
2026-02-04  9:40     ` Maxime Chevallier
2026-02-04 19:58   ` Heiko Stübner
2026-02-04 19:58     ` Heiko Stübner
2026-02-04  9:14 ` [PATCH net-next 3/6] net: stmmac: rk: rk3328: gmac2phy only supports RMII Russell King (Oracle)
2026-02-04  9:14   ` Russell King (Oracle)
2026-02-04  9:43   ` Maxime Chevallier
2026-02-04  9:43     ` Maxime Chevallier
2026-02-04 20:00   ` Heiko Stübner
2026-02-04 20:00     ` Heiko Stübner
2026-02-04  9:14 ` [PATCH net-next 4/6] net: stmmac: rk: rk3528: gmac0 " Russell King (Oracle)
2026-02-04  9:14   ` Russell King (Oracle)
2026-02-04  9:43   ` Maxime Chevallier
2026-02-04  9:43     ` Maxime Chevallier
2026-02-04 20:01   ` Heiko Stübner
2026-02-04 20:01     ` Heiko Stübner
2026-02-04  9:14 ` [PATCH net-next 5/6] net: stmmac: rk: use rk_encode_wm16() for clock selection Russell King (Oracle)
2026-02-04  9:14   ` Russell King (Oracle)
2026-02-04 22:03   ` Heiko Stübner
2026-02-04 22:03     ` Heiko Stübner
2026-02-04 22:26     ` Russell King (Oracle)
2026-02-04 22:26       ` Russell King (Oracle)
2026-02-05  7:44       ` Heiko Stübner
2026-02-05  7:44         ` Heiko Stübner
2026-02-04  9:14 ` [PATCH net-next 6/6] net: stmmac: rk: rk3506, rk3528 and rk3588 have rmii_mode in clock register Russell King (Oracle)
2026-02-04  9:14   ` Russell King (Oracle)
2026-02-04 21:54   ` Heiko Stübner [this message]
2026-02-04 21:54     ` Heiko Stübner
2026-02-05 17:30 ` [PATCH net-next 0/6] net: stmmac: rk: final cleanups part patchwork-bot+netdevbpf
2026-02-05 17:30   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3238497.eGJsNajkDb@diego \
    --to=heiko@sntech.de \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.