From: Stephan Mueller <smueller@chronox.de>
To: herbert@gondor.apana.org.au, kernel test robot <lkp@intel.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-crypto@vger.kernel.org, simo@redhat.com,
Nicolai Stange <nstange@suse.de>
Subject: Re: [PATCH 1/7] crypto: DRBG - remove internal reseeding operation
Date: Wed, 26 Jan 2022 14:44:08 +0100 [thread overview]
Message-ID: <32397848.ByM7UNSnkf@tauon.chronox.de> (raw)
In-Reply-To: <202201262050.xFgnR1Kx-lkp@intel.com>
Am Mittwoch, 26. Januar 2022, 13:15:04 CET schrieb kernel test robot:
Hi,
> crypto/drbg.c:204:30: warning: unused function 'drbg_sec_strength'
> [-Wunused-function] static inline unsigned short
> drbg_sec_strength(drbg_flag_t flags) ^
It is interesting that Sparse did not complain about this. Anyhow, this
function is not needed and will be removed.
>
> >> crypto/drbg.c:1742:2: error: call to __compiletime_assert_223 declared
> >> with 'error' attribute: BUILD_BUG_ON failed: ARRAY_SIZE(drbg_cores) !=
> >> ARRAY_SIZE(drbg_algs)
> BUILD_BUG_ON(ARRAY_SIZE(drbg_cores) != ARRAY_SIZE(drbg_algs));
Correct, it should be > instead of != :-)
This will be fixed in the new code base
Thanks!
Ciao
Stephan
WARNING: multiple messages have this Message-ID (diff)
From: Stephan Mueller <smueller@chronox.de>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/7] crypto: DRBG - remove internal reseeding operation
Date: Wed, 26 Jan 2022 14:44:08 +0100 [thread overview]
Message-ID: <32397848.ByM7UNSnkf@tauon.chronox.de> (raw)
In-Reply-To: <202201262050.xFgnR1Kx-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 751 bytes --]
Am Mittwoch, 26. Januar 2022, 13:15:04 CET schrieb kernel test robot:
Hi,
> crypto/drbg.c:204:30: warning: unused function 'drbg_sec_strength'
> [-Wunused-function] static inline unsigned short
> drbg_sec_strength(drbg_flag_t flags) ^
It is interesting that Sparse did not complain about this. Anyhow, this
function is not needed and will be removed.
>
> >> crypto/drbg.c:1742:2: error: call to __compiletime_assert_223 declared
> >> with 'error' attribute: BUILD_BUG_ON failed: ARRAY_SIZE(drbg_cores) !=
> >> ARRAY_SIZE(drbg_algs)
> BUILD_BUG_ON(ARRAY_SIZE(drbg_cores) != ARRAY_SIZE(drbg_algs));
Correct, it should be > instead of != :-)
This will be fixed in the new code base
Thanks!
Ciao
Stephan
next prev parent reply other threads:[~2022-01-26 13:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 7:02 [PATCH 0/7] Common entropy source and DRNG management Stephan Müller
2022-01-26 7:03 ` [PATCH 1/7] crypto: DRBG - remove internal reseeding operation Stephan Müller
2022-01-26 12:15 ` kernel test robot
2022-01-26 12:15 ` kernel test robot
2022-01-26 13:44 ` Stephan Mueller [this message]
2022-01-26 13:44 ` Stephan Mueller
2022-01-26 7:03 ` [PATCH 2/7] crypto: AF_ALG - remove ALG_SET_DRBG_ENTROPY interface Stephan Müller
2022-01-26 7:04 ` [PATCH 3/7] crypto: Entropy Source and DRNG Manager Stephan Müller
2022-01-26 7:04 ` [PATCH 4/7] crypto: move Jitter RNG header include dir Stephan Müller
2022-01-26 7:04 ` [PATCH 5/7] crypto: ESDM - add Jitter RNG entropy source Stephan Müller
2022-01-26 7:05 ` [PATCH 6/7] crypto: ESDM - add Kernel " Stephan Müller
2022-01-26 7:05 ` [PATCH 7/7] crypto: ESDM - add kernel crypto API RNG interface Stephan Müller
2022-01-26 22:49 ` [PATCH 0/7] Common entropy source and DRNG management Eric Biggers
2022-01-28 15:37 ` Stephan Mueller
2022-01-28 18:51 ` Eric Biggers
2022-02-05 3:50 ` Herbert Xu
2022-02-06 16:02 ` Stephan Mueller
-- strict thread matches above, loose matches on Subject: below --
2022-01-26 11:54 [PATCH 1/7] crypto: DRBG - remove internal reseeding operation kernel test robot
2022-01-26 13:57 kernel test robot
2022-01-26 13:57 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32397848.ByM7UNSnkf@tauon.chronox.de \
--to=smueller@chronox.de \
--cc=herbert@gondor.apana.org.au \
--cc=kbuild-all@lists.01.org \
--cc=linux-crypto@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=nstange@suse.de \
--cc=simo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.