From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
linux-arm-kernel@lists.infradead.org
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux@ew.tq-group.com,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/2] spi: dt-bindings: introduce linux,use-rt-queue flag
Date: Fri, 09 Jun 2023 10:15:37 +0200 [thread overview]
Message-ID: <3241150.44csPzL39Z@steina-w> (raw)
In-Reply-To: <CACRpkdb=2fogk3bEa4fkPVYQivnvLh1F1TnBj7og43ak+F8gPw@mail.gmail.com>
Hi all,
Am Freitag, 9. Juni 2023, 09:41:14 CEST schrieb Linus Walleij:
> On Wed, Jun 7, 2023 at 2:55 PM Matthias Schiffer
>
> <matthias.schiffer@ew.tq-group.com> wrote:
> > It is not clear to me what alternative options we currently have if we
> > want a setting to be effective from the very beginning, before
> > userspace is running. Of course adding a cmdline option would work, but
> > that seems worse than having it in the DT in every possible way.
>
> A agree with Mark that a command line option isn't that bad. It's something
> that pertains to just the Linux kernel after all? And you can put that
> command line option in the default device tree, in chosen, if you want.
I don't like the idea of a command line enabling realtime scheduling for all
instances of the SPI controller driver or even all SPI controllers. Actually
this might be worse if a non-rt SPI bus is considered for RT scheduling.
IMHO this should be configurable per SPI controller, e.g. a sysfs attribute.
> No-one is going to
> complain about that.
IIRC someone (maybe Greg K-H) opposed pretty hard against (module) parameters
for (driver) configuration, but I can't find the post to back my statement.
Best regards,
Alexander
> Yours,
> Linus Walleij
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
linux-arm-kernel@lists.infradead.org
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux@ew.tq-group.com,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/2] spi: dt-bindings: introduce linux,use-rt-queue flag
Date: Fri, 09 Jun 2023 10:15:37 +0200 [thread overview]
Message-ID: <3241150.44csPzL39Z@steina-w> (raw)
In-Reply-To: <CACRpkdb=2fogk3bEa4fkPVYQivnvLh1F1TnBj7og43ak+F8gPw@mail.gmail.com>
Hi all,
Am Freitag, 9. Juni 2023, 09:41:14 CEST schrieb Linus Walleij:
> On Wed, Jun 7, 2023 at 2:55 PM Matthias Schiffer
>
> <matthias.schiffer@ew.tq-group.com> wrote:
> > It is not clear to me what alternative options we currently have if we
> > want a setting to be effective from the very beginning, before
> > userspace is running. Of course adding a cmdline option would work, but
> > that seems worse than having it in the DT in every possible way.
>
> A agree with Mark that a command line option isn't that bad. It's something
> that pertains to just the Linux kernel after all? And you can put that
> command line option in the default device tree, in chosen, if you want.
I don't like the idea of a command line enabling realtime scheduling for all
instances of the SPI controller driver or even all SPI controllers. Actually
this might be worse if a non-rt SPI bus is considered for RT scheduling.
IMHO this should be configurable per SPI controller, e.g. a sysfs attribute.
> No-one is going to
> complain about that.
IIRC someone (maybe Greg K-H) opposed pretty hard against (module) parameters
for (driver) configuration, but I can't find the post to back my statement.
Best regards,
Alexander
> Yours,
> Linus Walleij
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-09 8:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 11:52 [PATCH 1/2] spi: dt-bindings: introduce linux,use-rt-queue flag Matthias Schiffer
2023-06-02 11:52 ` Matthias Schiffer
2023-06-02 11:52 ` [PATCH 2/2] spi: add support for generic " Matthias Schiffer
2023-06-02 11:52 ` Matthias Schiffer
2023-06-02 12:22 ` [PATCH 1/2] spi: dt-bindings: introduce " Mark Brown
2023-06-02 12:22 ` Mark Brown
2023-06-06 14:37 ` Linus Walleij
2023-06-06 14:37 ` Linus Walleij
2023-06-06 14:44 ` Mark Brown
2023-06-06 14:44 ` Mark Brown
2023-06-07 12:55 ` Matthias Schiffer
2023-06-07 12:55 ` Matthias Schiffer
2023-06-07 14:21 ` Mark Brown
2023-06-07 14:21 ` Mark Brown
2023-06-07 14:28 ` Krzysztof Kozlowski
2023-06-07 14:28 ` Krzysztof Kozlowski
2023-06-09 7:41 ` Linus Walleij
2023-06-09 7:41 ` Linus Walleij
2023-06-09 8:15 ` Alexander Stein [this message]
2023-06-09 8:15 ` Alexander Stein
2023-06-09 8:42 ` Linus Walleij
2023-06-09 8:42 ` Linus Walleij
2023-06-09 9:13 ` Alexander Stein
2023-06-09 9:13 ` Alexander Stein
2023-06-09 9:22 ` Linus Walleij
2023-06-09 9:22 ` Linus Walleij
2023-06-09 9:34 ` Mark Brown
2023-06-09 9:34 ` Mark Brown
2023-06-09 9:33 ` Mark Brown
2023-06-09 9:33 ` Mark Brown
2023-06-14 19:30 ` Rob Herring
2023-06-14 19:30 ` Rob Herring
2023-06-14 19:59 ` Linus Walleij
2023-06-14 19:59 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3241150.44csPzL39Z@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.