* [patch] usb gadget: uvc: use capped length value
@ 2013-03-14 8:01 Dan Carpenter
2013-03-14 14:09 ` Laurent Pinchart
2013-03-14 14:18 ` Felipe Balbi
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-03-14 8:01 UTC (permalink / raw)
To: kernel-janitors
"req->length" is a capped version of "data->length".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Static analysis. I have not tested this.
diff --git a/drivers/usb/gadget/uvc_v4l2.c b/drivers/usb/gadget/uvc_v4l2.c
index 2ca9386..8770cf0 100644
--- a/drivers/usb/gadget/uvc_v4l2.c
+++ b/drivers/usb/gadget/uvc_v4l2.c
@@ -43,7 +43,7 @@ uvc_send_response(struct uvc_device *uvc, struct uvc_request_data *data)
req->zero = data->length < uvc->event_length;
req->dma = DMA_ADDR_INVALID;
- memcpy(req->buf, data->data, data->length);
+ memcpy(req->buf, data->data, req->length);
return usb_ep_queue(cdev->gadget->ep0, req, GFP_KERNEL);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] usb gadget: uvc: use capped length value
2013-03-14 8:01 [patch] usb gadget: uvc: use capped length value Dan Carpenter
@ 2013-03-14 14:09 ` Laurent Pinchart
2013-03-14 14:18 ` Felipe Balbi
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2013-03-14 14:09 UTC (permalink / raw)
To: kernel-janitors
Hi Dan,
Thanks for the patch.
On Thursday 14 March 2013 11:01:05 Dan Carpenter wrote:
> "req->length" is a capped version of "data->length".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Good catch.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Felipe, could you please pick this one up (I can of course send you a pull
request if preferred) ?
> ---
> Static analysis. I have not tested this.
>
> diff --git a/drivers/usb/gadget/uvc_v4l2.c b/drivers/usb/gadget/uvc_v4l2.c
> index 2ca9386..8770cf0 100644
> --- a/drivers/usb/gadget/uvc_v4l2.c
> +++ b/drivers/usb/gadget/uvc_v4l2.c
> @@ -43,7 +43,7 @@ uvc_send_response(struct uvc_device *uvc, struct
> uvc_request_data *data) req->zero = data->length < uvc->event_length;
> req->dma = DMA_ADDR_INVALID;
>
> - memcpy(req->buf, data->data, data->length);
> + memcpy(req->buf, data->data, req->length);
>
> return usb_ep_queue(cdev->gadget->ep0, req, GFP_KERNEL);
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] usb gadget: uvc: use capped length value
2013-03-14 8:01 [patch] usb gadget: uvc: use capped length value Dan Carpenter
2013-03-14 14:09 ` Laurent Pinchart
@ 2013-03-14 14:18 ` Felipe Balbi
1 sibling, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2013-03-14 14:18 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
On Thu, Mar 14, 2013 at 03:09:46PM +0100, Laurent Pinchart wrote:
> Hi Dan,
>
> Thanks for the patch.
>
> On Thursday 14 March 2013 11:01:05 Dan Carpenter wrote:
> > "req->length" is a capped version of "data->length".
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Good catch.
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Felipe, could you please pick this one up (I can of course send you a pull
> request if preferred) ?
sure thing, no need to worry with building a branch ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-14 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-14 8:01 [patch] usb gadget: uvc: use capped length value Dan Carpenter
2013-03-14 14:09 ` Laurent Pinchart
2013-03-14 14:18 ` Felipe Balbi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.