From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] hugetlb: check for requested huge pages first
Date: Wed, 22 Apr 2020 08:31:53 -0400 (EDT) [thread overview]
Message-ID: <329264999.9436008.1587558713031.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAEemH2e_h+4_nMTaVVtu9ngewvV_qrzVvtnKrqhQPCzZxDY80w@mail.gmail.com>
----- Original Message -----
> On Wed, Apr 22, 2020 at 7:40 PM Jan Stancek <jstancek@redhat.com> wrote:
>
> > /sys/kernel/mm/hugepages is not present when there are no
> > supported hugepage sizes. This is common for ppc64le KVM guests,
> > when hypervisor does not enable hugepages. Guest will boot with:
> > hugetlbfs: disabling because there are no supported hugepage sizes
> >
> > # cat /proc/filesystems | grep huge; echo $?
> > 1
> >
> > Move the check up in setup to check it as first thing to avoid
> > running into TBROK on mount or set_sys_tune when hugetlbfs is
> > not available:
> > safe_macros.c:766: BROK: hugemmap01.c:82: mount(none,
> > /mnt/testarea/ltp-07Kg6lCOmm/Ai9D0M, hugetlbfs, 0, (nil)) failed: ENODEV
> > (19)
> > safe_macros.c:766: BROK: hugemmap02.c:129: mount(none,
> > /mnt/testarea/ltp-07Kg6lCOmm/Cxf7A6, hugetlbfs, 0, (nil)) failed: ENODEV
> > (19)
> > safe_macros.c:766: BROK: hugemmap04.c:100: mount(none,
> > /mnt/testarea/ltp-07Kg6lCOmm/kS60Mk, hugetlbfs, 0, (nil)) failed: ENODEV
> > (19)
> > safe_file_ops.c:219: BROK: Expected 1 conversions got 0 at
> > hugemmap06.c:42
> > safe_file_ops.c:155: BROK: The FILE '/proc/sys/vm/nr_hugepages' ended
> > prematurely at mem.c:836
> > safe_file_ops.c:219: BROK: Expected 1 conversions got 0 at
> > hugeshmat05.c:39
> >
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
> >
> Acked-by: Li Wang <liwang@redhat.com>
>
> This is obviously right! ACK.
Pushed.
prev parent reply other threads:[~2020-04-22 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 7:13 [LTP] [PATCH] lib/tst_hugepage: TCONF when huge pages are not supported Jan Stancek
2020-04-22 8:29 ` Li Wang
2020-04-22 11:33 ` Jan Stancek
2020-04-22 11:40 ` [LTP] [PATCH v2] hugetlb: check for requested huge pages first Jan Stancek
2020-04-22 11:49 ` Li Wang
2020-04-22 12:31 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=329264999.9436008.1587558713031.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.