From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lib/tst_hugepage: TCONF when huge pages are not supported
Date: Wed, 22 Apr 2020 07:33:43 -0400 (EDT) [thread overview]
Message-ID: <431757761.9427972.1587555223323.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAEemH2fWhXzLRV+g=hN9yJRcmqsj2iGMxxy14GGGKDpBAEX5HQ@mail.gmail.com>
----- Original Message -----
> > if (access(PATH_HUGEPAGES, F_OK)) {
> > tst_hugepages = 0;
> > - goto out;
> > + tst_brk(TCONF, "Huge pages not supported.");
> >
>
> We don't do that because hugetlb is not the hard requirement for some tests
> (i.e pkey01.c). If we exit with TCONF at an early phase on a non-hugetlb
> system the remaining test will be missed too. In a word, the goto out here
> is on purpose.
Then it's a bit strange it TBROKs if it can't reserve enough huge pages.
I'll send v2, that's checking tst_hugepages. Almost all tests appear to have the
check already, it just needs to be moved up a little in setup().
next prev parent reply other threads:[~2020-04-22 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 7:13 [LTP] [PATCH] lib/tst_hugepage: TCONF when huge pages are not supported Jan Stancek
2020-04-22 8:29 ` Li Wang
2020-04-22 11:33 ` Jan Stancek [this message]
2020-04-22 11:40 ` [LTP] [PATCH v2] hugetlb: check for requested huge pages first Jan Stancek
2020-04-22 11:49 ` Li Wang
2020-04-22 12:31 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431757761.9427972.1587555223323.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.