All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Don't bother trying to add rgrps to the lru list
Date: Wed, 26 Jul 2017 11:26:48 -0400 (EDT)	[thread overview]
Message-ID: <329827946.34644924.1501082808245.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <598159098.34643831.1501082572029.JavaMail.zimbra@redhat.com>

Hi,

This patch removes a call to gfs2_glock_add_to_lru from function
gfs2_clear_rgrpd, which is called when GFS2 is removing all the
rgrps from memory. The call is just a waste of time because as soon
as it adds it to the lru_list, the subsequent call to gfs2_glock_put
takes it back off again. It doesn't make sense for the rgrps to ever
be on the lru list anyway because gfs2_rgrp_glops doesn't even have
the GLOF_LRU bit set (by design).

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
 fs/gfs2/rgrp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 836e38ba5d0a..29fbeee36fa6 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -706,7 +706,6 @@ void gfs2_clear_rgrpd(struct gfs2_sbd *sdp)
 
 		if (gl) {
 			glock_set_object(gl, NULL);
-			gfs2_glock_add_to_lru(gl);
 			gfs2_glock_put(gl);
 		}
 



       reply	other threads:[~2017-07-26 15:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <598159098.34643831.1501082572029.JavaMail.zimbra@redhat.com>
2017-07-26 15:26 ` Bob Peterson [this message]
2017-07-26 15:38   ` [Cluster-devel] [GFS2 PATCH] GFS2: Don't bother trying to add rgrps to the lru list Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=329827946.34644924.1501082808245.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.