From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Anand Gadiyar <gadiyar@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
linux-arm-kernel@lists.infradead.org,
Paul Walmsley <paul@pwsan.com>
Subject: RE: [PATCH] omap3: clocks: Fix build error 'CK_3430ES2' undeclared here
Date: Mon, 10 Jan 2011 19:10:22 +0530 [thread overview]
Message-ID: <32cc9f4ba82187480f1e4d15d4e93dc0@mail.gmail.com> (raw)
In-Reply-To: <4D2B0B86.3010201@ti.com>
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Anand Gadiyar
> Sent: Monday, January 10, 2011 7:07 PM
> To: Santosh Shilimkar
> Cc: linux-omap@vger.kernel.org; tony@atomide.com; linux-arm-
> kernel@lists.infradead.org; Paul Walmsley
> Subject: Re: [PATCH] omap3: clocks: Fix build error 'CK_3430ES2'
> undeclared here
>
> On 1/10/2011 3:46 AM, Santosh Shilimkar wrote:
> > At latest mainline commit 0c21e3aaf6a, omap2plus build is broken.
> This
> > patch is trivial fix for the missed usb clock node for
> CK_3430ES2PLUS
> > flag update.
> >
> > CHK include/generated/compile.h
> > CC arch/arm/mach-omap2/clock3xxx_data.o
> > arch/arm/mach-omap2/clock3xxx_data.c:3289: error: 'CK_3430ES2'
> undeclared
> > here (not in a function)
> > make[1]: *** [arch/arm/mach-omap2/clock3xxx_data.o] Error 1
> > make: *** [arch/arm/mach-omap2] Error 2
> >
> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > ---
> > arch/arm/mach-omap2/clock3xxx_data.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-
> omap2/clock3xxx_data.c
> > index d3ab1c9..c54cc33 100644
> > --- a/arch/arm/mach-omap2/clock3xxx_data.c
> > +++ b/arch/arm/mach-omap2/clock3xxx_data.c
> > @@ -3286,7 +3286,7 @@ static struct omap_clk omap3xxx_clks[] = {
> > CLK(NULL, "cpefuse_fck", &cpefuse_fck, CK_3430ES2PLUS
> | CK_AM35XX | CK_36XX),
> > CLK(NULL, "ts_fck", &ts_fck, CK_3430ES2PLUS |
CK_AM35XX
> | CK_36XX),
> > CLK(NULL, "usbtll_fck", &usbtll_fck, CK_3430ES2PLUS
> | CK_AM35XX | CK_36XX),
> > - CLK("ehci-omap.0", "usbtll_fck", &usbtll_fck,
> CK_3430ES2 | CK_AM35XX),
> > + CLK("ehci-omap.0", "usbtll_fck", &usbtll_fck,
> CK_3430ES2PLUS | CK_AM35XX),
>
> Was about to post something similar.
>
> Can you update this line to add CK_36XX as well. Without this, we
> won't be able to use
> the USBHOST on 36xx/37xx platforms.
>
> With this, feel free to add my
> Acked-by: Anand Gadiyar <gadiyar@ti.com>
>
ok. I can add CK_36XX and repost it with your ack
> - Anand
>
> > CLK("omap-mcbsp.1", "prcm_fck", &core_96m_fck,
> CK_3XXX),
> > CLK("omap-mcbsp.5", "prcm_fck", &core_96m_fck,
> CK_3XXX),
> > CLK(NULL, "core_96m_fck", &core_96m_fck, CK_3XXX),
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap3: clocks: Fix build error 'CK_3430ES2' undeclared here
Date: Mon, 10 Jan 2011 19:10:22 +0530 [thread overview]
Message-ID: <32cc9f4ba82187480f1e4d15d4e93dc0@mail.gmail.com> (raw)
In-Reply-To: <4D2B0B86.3010201@ti.com>
> -----Original Message-----
> From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-
> owner at vger.kernel.org] On Behalf Of Anand Gadiyar
> Sent: Monday, January 10, 2011 7:07 PM
> To: Santosh Shilimkar
> Cc: linux-omap at vger.kernel.org; tony at atomide.com; linux-arm-
> kernel at lists.infradead.org; Paul Walmsley
> Subject: Re: [PATCH] omap3: clocks: Fix build error 'CK_3430ES2'
> undeclared here
>
> On 1/10/2011 3:46 AM, Santosh Shilimkar wrote:
> > At latest mainline commit 0c21e3aaf6a, omap2plus build is broken.
> This
> > patch is trivial fix for the missed usb clock node for
> CK_3430ES2PLUS
> > flag update.
> >
> > CHK include/generated/compile.h
> > CC arch/arm/mach-omap2/clock3xxx_data.o
> > arch/arm/mach-omap2/clock3xxx_data.c:3289: error: 'CK_3430ES2'
> undeclared
> > here (not in a function)
> > make[1]: *** [arch/arm/mach-omap2/clock3xxx_data.o] Error 1
> > make: *** [arch/arm/mach-omap2] Error 2
> >
> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > ---
> > arch/arm/mach-omap2/clock3xxx_data.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-
> omap2/clock3xxx_data.c
> > index d3ab1c9..c54cc33 100644
> > --- a/arch/arm/mach-omap2/clock3xxx_data.c
> > +++ b/arch/arm/mach-omap2/clock3xxx_data.c
> > @@ -3286,7 +3286,7 @@ static struct omap_clk omap3xxx_clks[] = {
> > CLK(NULL, "cpefuse_fck", &cpefuse_fck, CK_3430ES2PLUS
> | CK_AM35XX | CK_36XX),
> > CLK(NULL, "ts_fck", &ts_fck, CK_3430ES2PLUS |
CK_AM35XX
> | CK_36XX),
> > CLK(NULL, "usbtll_fck", &usbtll_fck, CK_3430ES2PLUS
> | CK_AM35XX | CK_36XX),
> > - CLK("ehci-omap.0", "usbtll_fck", &usbtll_fck,
> CK_3430ES2 | CK_AM35XX),
> > + CLK("ehci-omap.0", "usbtll_fck", &usbtll_fck,
> CK_3430ES2PLUS | CK_AM35XX),
>
> Was about to post something similar.
>
> Can you update this line to add CK_36XX as well. Without this, we
> won't be able to use
> the USBHOST on 36xx/37xx platforms.
>
> With this, feel free to add my
> Acked-by: Anand Gadiyar <gadiyar@ti.com>
>
ok. I can add CK_36XX and repost it with your ack
> - Anand
>
> > CLK("omap-mcbsp.1", "prcm_fck", &core_96m_fck,
> CK_3XXX),
> > CLK("omap-mcbsp.5", "prcm_fck", &core_96m_fck,
> CK_3XXX),
> > CLK(NULL, "core_96m_fck", &core_96m_fck, CK_3XXX),
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-10 13:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 22:16 [PATCH] omap3: clocks: Fix build error 'CK_3430ES2' undeclared here Santosh Shilimkar
2011-01-09 22:16 ` Santosh Shilimkar
2011-01-10 13:37 ` Anand Gadiyar
2011-01-10 13:37 ` Anand Gadiyar
2011-01-10 13:40 ` Santosh Shilimkar [this message]
2011-01-10 13:40 ` Santosh Shilimkar
2011-01-10 18:58 ` Paul Walmsley
2011-01-10 18:58 ` Paul Walmsley
2011-01-10 18:58 ` Paul Walmsley
2011-01-10 18:58 ` Paul Walmsley
2011-01-10 19:07 ` Tony Lindgren
2011-01-10 19:07 ` Tony Lindgren
2011-01-10 22:30 ` Tony Lindgren
2011-01-10 22:30 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32cc9f4ba82187480f1e4d15d4e93dc0@mail.gmail.com \
--to=santosh.shilimkar@ti.com \
--cc=gadiyar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.