From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Daniel Palmer <daniel@thingy.jp>
Cc: Romain Perier <romain.perier@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: mstar: align UART node name with bindings
Date: Wed, 25 Jan 2023 11:37:41 +0100 [thread overview]
Message-ID: <32db06ef-e6c1-d8ed-8624-cf91db5b3e53@linaro.org> (raw)
In-Reply-To: <CAFr9PXn+XMzz8uZzNwDNdCpYeN4Nf6rc6nXWvuf_TCRe2B_PXw@mail.gmail.com>
On 25/01/2023 11:20, Daniel Palmer wrote:
> Hi,
>
> On Tue, 24 Jan 2023 at 00:15, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Bindings expect UART/serial node names to be "serial".
>
> snip
>
>> - pm_uart: uart@221000 {
>> + pm_uart: serial@221000 {
>> compatible = "ns16550a";
>> reg = <0x221000 0x100>;
>> reg-shift = <3>;
>> --
>> 2.34.1
>>
>
> I have this change in my changes to use the proper uart driver that I
> need to fix up and resend but it doesn't hurt to fix it now.
>
> Reviewed-by: Daniel Palmer <daniel@thingy.jp>
>
> But we don't have anything queued up in our tree to send a PR for so
> maybe this should be merged via soc.
I can take it with my other cleanups. Thanks.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Daniel Palmer <daniel@thingy.jp>
Cc: Romain Perier <romain.perier@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: mstar: align UART node name with bindings
Date: Wed, 25 Jan 2023 11:37:41 +0100 [thread overview]
Message-ID: <32db06ef-e6c1-d8ed-8624-cf91db5b3e53@linaro.org> (raw)
In-Reply-To: <CAFr9PXn+XMzz8uZzNwDNdCpYeN4Nf6rc6nXWvuf_TCRe2B_PXw@mail.gmail.com>
On 25/01/2023 11:20, Daniel Palmer wrote:
> Hi,
>
> On Tue, 24 Jan 2023 at 00:15, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Bindings expect UART/serial node names to be "serial".
>
> snip
>
>> - pm_uart: uart@221000 {
>> + pm_uart: serial@221000 {
>> compatible = "ns16550a";
>> reg = <0x221000 0x100>;
>> reg-shift = <3>;
>> --
>> 2.34.1
>>
>
> I have this change in my changes to use the proper uart driver that I
> need to fix up and resend but it doesn't hurt to fix it now.
>
> Reviewed-by: Daniel Palmer <daniel@thingy.jp>
>
> But we don't have anything queued up in our tree to send a PR for so
> maybe this should be merged via soc.
I can take it with my other cleanups. Thanks.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-25 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 15:15 [PATCH] ARM: dts: mstar: align UART node name with bindings Krzysztof Kozlowski
2023-01-23 15:15 ` Krzysztof Kozlowski
2023-01-25 10:20 ` Daniel Palmer
2023-01-25 10:20 ` Daniel Palmer
2023-01-25 10:37 ` Krzysztof Kozlowski [this message]
2023-01-25 10:37 ` Krzysztof Kozlowski
2023-01-25 10:39 ` Krzysztof Kozlowski
2023-01-25 10:39 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32db06ef-e6c1-d8ed-8624-cf91db5b3e53@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=daniel@thingy.jp \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.