From: Stephen Boyd <sboyd@kernel.org>
To: Mohammad Rafi Shaik <quic_mohs@quicinc.com>,
agross@kernel.org, andersson@kernel.org, broonie@kernel.org,
konrad.dybcio@somainline.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, mturquette@baylibre.com,
quic_plai@quicinc.com, quic_rohkumar@quicinc.com,
quic_visr@quicinc.com, robh+dt@kernel.org, swboyd@chromium.org
Cc: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Subject: Re: [PATCH v10 2/3] clk: qcom: lpasscc-sc7280: Skip qdsp6ss clock registration
Date: Fri, 31 Mar 2023 11:46:32 -0700 [thread overview]
Message-ID: <32e439d2fb2db190cd1486b2bd15aab3.sboyd@kernel.org> (raw)
In-Reply-To: <20230331152805.3199968-3-quic_mohs@quicinc.com>
Quoting Mohammad Rafi Shaik (2023-03-31 08:28:04)
> diff --git a/drivers/clk/qcom/lpasscc-sc7280.c b/drivers/clk/qcom/lpasscc-sc7280.c
> index 5c1e17bd0d76..24aeed6bcf0e 100644
> --- a/drivers/clk/qcom/lpasscc-sc7280.c
> +++ b/drivers/clk/qcom/lpasscc-sc7280.c
> @@ -17,6 +17,8 @@
> #include "clk-branch.h"
> #include "common.h"
>
> +#define QDSP6SS_MAX_REGISTER 0x3f
You can drop the define and just put the raw number in the one place
this is used.
> +
> static struct clk_branch lpass_top_cc_lpi_q6_axim_hs_clk = {
> .halt_reg = 0x0,
> .halt_check = BRANCH_HALT,
> @@ -118,12 +120,15 @@ static int lpass_cc_sc7280_probe(struct platform_device *pdev)
> goto destroy_pm_clk;
> }
>
> - lpass_regmap_config.name = "qdsp6ss";
> - desc = &lpass_qdsp6ss_sc7280_desc;
> + if (!of_property_read_bool(pdev->dev.of_node, "qcom,adsp-pil-mode")) {
> + lpass_regmap_config.name = "qdsp6ss";
> + lpass_regmap_config.max_register = QDSP6SS_MAX_REGISTER;
> + desc = &lpass_qdsp6ss_sc7280_desc;
>
next prev parent reply other threads:[~2023-03-31 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 15:28 [PATCH v10 0/3] Add resets for ADSP based audio clock controller driver Mohammad Rafi Shaik
2023-03-31 15:28 ` [PATCH v10 1/3] dt-bindings: clock: qcom,sc7280-lpasscc: Add qcom,adsp-pil-mode property Mohammad Rafi Shaik
2023-03-31 15:28 ` [PATCH v10 2/3] clk: qcom: lpasscc-sc7280: Skip qdsp6ss clock registration Mohammad Rafi Shaik
2023-03-31 18:46 ` Stephen Boyd [this message]
2023-04-03 6:39 ` Mohammad Rafi Shaik
2023-03-31 15:28 ` [PATCH v10 3/3] clk: qcom: lpassaudiocc-sc7280: Add required gdsc power domain clks in lpass_cc_sc7280_desc Mohammad Rafi Shaik
2023-03-31 18:48 ` [PATCH v10 0/3] Add resets for ADSP based audio clock controller driver Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32e439d2fb2db190cd1486b2bd15aab3.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_mohs@quicinc.com \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=quic_visr@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.