From: Markus Elfring <Markus.Elfring@web.de>
To: Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, cocci@inria.fr
Subject: Re: [cocci] [0/3] dmaengine: timb_dma: Adjustments for td_alloc_init_desc()
Date: Mon, 22 Jan 2024 13:15:36 +0100 [thread overview]
Message-ID: <32eef8de-1e95-4e4e-85c5-9cc881b75bdf@web.de> (raw)
In-Reply-To: <Za5SW6xdsOFylD7x@matsya>
>> A few update suggestions were taken into account
>> from static source code analysis.
>
> was this anaysis done by you
Mostly, yes.
> or some tool reported this.
Some scripts for the semantic patch language (Coccinelle software) can help
to point places out for desirable source code transformations.
> Frabkly I dont see much value in these patches,
It is a pity that you view the presented update steps in this direction.
> can you fix something real please
You might occasionally find adjustments from my patch selection more worthwhile.
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>, cocci@inria.fr
Subject: Re: [0/3] dmaengine: timb_dma: Adjustments for td_alloc_init_desc()
Date: Mon, 22 Jan 2024 13:15:36 +0100 [thread overview]
Message-ID: <32eef8de-1e95-4e4e-85c5-9cc881b75bdf@web.de> (raw)
In-Reply-To: <Za5SW6xdsOFylD7x@matsya>
>> A few update suggestions were taken into account
>> from static source code analysis.
>
> was this anaysis done by you
Mostly, yes.
> or some tool reported this.
Some scripts for the semantic patch language (Coccinelle software) can help
to point places out for desirable source code transformations.
> Frabkly I dont see much value in these patches,
It is a pity that you view the presented update steps in this direction.
> can you fix something real please
You might occasionally find adjustments from my patch selection more worthwhile.
Regards,
Markus
next prev parent reply other threads:[~2024-01-22 12:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-25 10:15 [cocci] [PATCH 0/3] dmaengine: timb_dma: Adjustments for td_alloc_init_desc() Markus Elfring
2023-12-25 10:15 ` Markus Elfring
2023-12-25 10:18 ` [cocci] [PATCH 1/3] dmaengine: timb_dma: Return directly after a failed kzalloc() in td_alloc_init_desc() Markus Elfring
2023-12-25 10:18 ` Markus Elfring
2023-12-25 10:20 ` [cocci] [PATCH 2/3] dmaengine: timb_dma: Improve a size determination " Markus Elfring
2023-12-25 10:20 ` Markus Elfring
2023-12-25 10:22 ` [cocci] [PATCH 3/3] dmaengine: timb_dma: One function call less in td_alloc_init_desc() after error detection Markus Elfring
2023-12-25 10:22 ` Markus Elfring
2024-01-22 11:32 ` [PATCH 0/3] dmaengine: timb_dma: Adjustments for td_alloc_init_desc() Vinod Koul
2024-01-22 12:15 ` Markus Elfring [this message]
2024-01-22 12:15 ` [0/3] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32eef8de-1e95-4e4e-85c5-9cc881b75bdf@web.de \
--to=markus.elfring@web.de \
--cc=cocci@inria.fr \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.