Re: [PATCH 08/21] ARM: shmobile: kzm9g: reference: Register pinctrl mappings for SCIF

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Simon,

Thank you for the patch.

On Wednesday 13 February 2013 11:44:44 Simon Horman wrote:
> Replace the GPIO-based SCIF pinmux configuration by pinctrl mappings.
> 
> This change is for the kzm9g reference DT implementation and
> is in keeping with a similar change for the default kzm9g implementation
> made by Laurent Pinchart.
> 
> Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Acked-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
>  arch/arm/mach-shmobile/board-kzm9g-reference.c |   10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-kzm9g-reference.c
> b/arch/arm/mach-shmobile/board-kzm9g-reference.c index 642bb7b..9d6fe22
> 100644
> --- a/arch/arm/mach-shmobile/board-kzm9g-reference.c
> +++ b/arch/arm/mach-shmobile/board-kzm9g-reference.c
> @@ -36,16 +36,14 @@
>  static const struct pinctrl_map kzm_pinctrl_map[] = {
>  	PIN_MAP_MUX_GROUP_DEFAULT("i2c-sh_mobile.3", "pfc-sh73a0",
>  				  "i2c3_1", "i2c3"),
> +	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.4", "pfc-sh73a0",
> +				  "scifa4_data", "scifa4"),
> +	PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.4", "pfc-sh73a0",
> +				  "scifa4_ctrl", "scifa4"),
>  };
> 
>  static void __init kzm_init(void)
>  {
> -	/* enable SCIFA4 */
> -	gpio_request(GPIO_FN_SCIFA4_TXD, NULL);
> -	gpio_request(GPIO_FN_SCIFA4_RXD, NULL);
> -	gpio_request(GPIO_FN_SCIFA4_RTS_, NULL);
> -	gpio_request(GPIO_FN_SCIFA4_CTS_, NULL);
> -
>  	/* enable MMCIF */
>  	gpio_request(GPIO_FN_MMCCLK0,		NULL);
>  	gpio_request(GPIO_FN_MMCCMD0_PU,	NULL);
-- 
Regards,

Laurent Pinchart