From: Tomasz Figa <tomasz.figa@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Praveen Paneri <p.paneri@samsung.com>,
linux-usb@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
balbi@ti.com, gregkh@linuxfoundation.org,
thomas.abraham@linaro.org, ben-linux@fluff.org,
broonie@opensource.wolfsonmicro.com, l.majewski@samsung.com,
kyungmin.park@samsung.com, grant.likely@secretlab.ca,
heiko@sntech.de
Subject: Re: [PATCH v5 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg
Date: Wed, 12 Sep 2012 18:21:02 +0200 [thread overview]
Message-ID: <33690123.AyeJMS7yMW@flatron> (raw)
In-Reply-To: <50506D2A.7040908@pengutronix.de>
Hi Praveen, Marc,
On Wednesday 12 of September 2012 13:08:26 Marc Kleine-Budde wrote:
> > +static const struct of_device_id samsung_usbphy_dt_match[];
> > +
> > +static inline int samsung_usbphy_get_driver_data(struct
> > platform_device *pdev) +{
> > +#ifdef CONFIG_OF
>
> if (IS_ENABLED(CONFIG_OF) && pdev->dev.of_node)
Is this check needed at all?
In case of CONFIG_OF disabled, of_node should always be NULL and there is a
dummy macro provided for of_match_node, so it should compile and work just
fine.
--
Best regards,
Tomasz Figa
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg
Date: Wed, 12 Sep 2012 18:21:02 +0200 [thread overview]
Message-ID: <33690123.AyeJMS7yMW@flatron> (raw)
In-Reply-To: <50506D2A.7040908@pengutronix.de>
Hi Praveen, Marc,
On Wednesday 12 of September 2012 13:08:26 Marc Kleine-Budde wrote:
> > +static const struct of_device_id samsung_usbphy_dt_match[];
> > +
> > +static inline int samsung_usbphy_get_driver_data(struct
> > platform_device *pdev) +{
> > +#ifdef CONFIG_OF
>
> if (IS_ENABLED(CONFIG_OF) && pdev->dev.of_node)
Is this check needed at all?
In case of CONFIG_OF disabled, of_node should always be NULL and there is a
dummy macro provided for of_match_node, so it should compile and work just
fine.
--
Best regards,
Tomasz Figa
next prev parent reply other threads:[~2012-09-12 16:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 10:45 [PATCH v5 0/5] usb: phy: samsung: Introducing usb phy driver for samsung SoCs Praveen Paneri
2012-09-12 10:45 ` Praveen Paneri
2012-09-12 10:45 ` [PATCH v5 3/5] ARM: S3C64XX: Removing old phy setup code Praveen Paneri
2012-09-12 10:45 ` Praveen Paneri
[not found] ` <1347446757-20519-1-git-send-email-p.paneri-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-09-12 10:45 ` [PATCH v5 1/5] usb: phy: samsung: Introducing usb phy driver for hsotg Praveen Paneri
2012-09-12 10:45 ` Praveen Paneri
2012-09-12 11:08 ` Marc Kleine-Budde
2012-09-12 11:08 ` Marc Kleine-Budde
2012-09-12 16:21 ` Tomasz Figa [this message]
2012-09-12 16:21 ` Tomasz Figa
2012-09-14 9:59 ` Praveen Paneri
2012-09-14 9:59 ` Praveen Paneri
2012-09-14 6:24 ` Praveen Paneri
2012-09-14 6:24 ` Praveen Paneri
2012-09-12 10:45 ` [PATCH v5 2/5] usb: s3c-hsotg: Adding phy driver support Praveen Paneri
2012-09-12 10:45 ` Praveen Paneri
2012-09-12 10:45 ` [PATCH v5 4/5] ARM: S3C64XX: Enabling samsung-usbphy driver Praveen Paneri
2012-09-12 10:45 ` Praveen Paneri
2012-09-12 10:45 ` [PATCH v5 5/5] ARM: Exynos4210: " Praveen Paneri
2012-09-12 10:45 ` Praveen Paneri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33690123.AyeJMS7yMW@flatron \
--to=tomasz.figa@gmail.com \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=l.majewski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=p.paneri@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.