All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Donnellan <ajd@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, x86@kernel.org,
	linux-riscv@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, pasha.tatashin@soleen.com,
	sweettea-kernel@dorminy.me, nicholas@linux.ibm.com,
	christophe.leroy@csgroup.eu, alexghiti@rivosinc.com
Subject: Re: [PATCH v17 00/12] Support page table check on PowerPC
Date: Fri, 26 Sep 2025 08:42:35 +1000	[thread overview]
Message-ID: <336c0402c59363956d0c4eefc1b8a059e1fcc8e4.camel@linux.ibm.com> (raw)
In-Reply-To: <20250909091335.183439-1-ajd@linux.ibm.com>

Hi Andrew,

On Tue, 2025-09-09 at 19:13 +1000, Andrew Donnellan wrote:
> Support page table check on all PowerPC platforms. This works by serialising
> assignments, reassignments and clears of page table entries at each level in
> order to ensure that anonymous mappings have at most one writable consumer,
> and likewise that file-backed mappings are not simultaneously also anonymous
> mappings.
> 
> In order to support this infrastructure, a number of helpers or stubs must be
> defined or updated for all powerpc platforms. Additionally, we separate
> set_pte_at() and set_pte_at_unchecked(), to allow for internal, uninstrumented
> mappings.
> 
> On some PowerPC platforms, implementing {pte,pmd,pud}_user_accessible_page()
> requires the address. We revert previous changes that removed the address
> parameter from various interfaces, and add it to some other interfaces,
> in order to allow this.
> 
> Note that on 32 bit systems with CONFIG_KFENCE=y, you need [0] to avoid
> possible failures in init code (this is a code patching/static keys issue,
> which was discovered by a user testing this series but isn't a bug in page
> table check).
> 
> (This series was initially written by Rohan McLure, who has left IBM and
> is no longer working on powerpc.)

Is this likely to make it in in time for 6.18, or should I respin it post merge
window?

Thanks,
Andrew

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited


WARNING: multiple messages have this Message-ID (diff)
From: Andrew Donnellan <ajd@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, x86@kernel.org,
	linux-riscv@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, pasha.tatashin@soleen.com,
	sweettea-kernel@dorminy.me, nicholas@linux.ibm.com,
	christophe.leroy@csgroup.eu, alexghiti@rivosinc.com
Subject: Re: [PATCH v17 00/12] Support page table check on PowerPC
Date: Fri, 26 Sep 2025 08:42:35 +1000	[thread overview]
Message-ID: <336c0402c59363956d0c4eefc1b8a059e1fcc8e4.camel@linux.ibm.com> (raw)
In-Reply-To: <20250909091335.183439-1-ajd@linux.ibm.com>

Hi Andrew,

On Tue, 2025-09-09 at 19:13 +1000, Andrew Donnellan wrote:
> Support page table check on all PowerPC platforms. This works by serialising
> assignments, reassignments and clears of page table entries at each level in
> order to ensure that anonymous mappings have at most one writable consumer,
> and likewise that file-backed mappings are not simultaneously also anonymous
> mappings.
> 
> In order to support this infrastructure, a number of helpers or stubs must be
> defined or updated for all powerpc platforms. Additionally, we separate
> set_pte_at() and set_pte_at_unchecked(), to allow for internal, uninstrumented
> mappings.
> 
> On some PowerPC platforms, implementing {pte,pmd,pud}_user_accessible_page()
> requires the address. We revert previous changes that removed the address
> parameter from various interfaces, and add it to some other interfaces,
> in order to allow this.
> 
> Note that on 32 bit systems with CONFIG_KFENCE=y, you need [0] to avoid
> possible failures in init code (this is a code patching/static keys issue,
> which was discovered by a user testing this series but isn't a bug in page
> table check).
> 
> (This series was initially written by Rohan McLure, who has left IBM and
> is no longer working on powerpc.)

Is this likely to make it in in time for 6.18, or should I respin it post merge
window?

Thanks,
Andrew

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2025-09-25 22:43 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09  9:13 [PATCH v17 00/12] Support page table check on PowerPC Andrew Donnellan
2025-09-09  9:13 ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 01/12] arm64/mm: Add addr parameter to __set_ptes_anysz() Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 02/12] arm64/mm: Add addr parameter to __ptep_get_and_clear_anysz() Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 03/12] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud[s]_set() Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 04/12] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd[s]_set() Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 05/12] mm/page_table_check: Provide addr parameter to page_table_check_ptes_set() Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 06/12] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pud_clear() Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 07/12] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pmd_clear() Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 08/12] mm/page_table_check: Reinstate address parameter in [__]page_table_check_pte_clear() Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 09/12] mm: Provide address parameter to p{te,md,ud}_user_accessible_page() Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 10/12] powerpc: mm: Implement *_user_accessible_page() for ptes Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 11/12] powerpc: mm: Use set_pte_at_unchecked() for internal usages Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-09  9:13 ` [PATCH v17 12/12] powerpc: mm: Support page table check Andrew Donnellan
2025-09-09  9:13   ` Andrew Donnellan
2025-09-25 22:42 ` Andrew Donnellan [this message]
2025-09-25 22:42   ` [PATCH v17 00/12] Support page table check on PowerPC Andrew Donnellan
2025-09-25 23:17   ` Andrew Morton
2025-09-25 23:17     ` Andrew Morton
2025-12-12  3:35     ` Pasha Tatashin
2025-12-12  3:35       ` Pasha Tatashin
2025-12-12  3:37       ` Andrew Donnellan
2025-12-12  3:37         ` Andrew Donnellan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=336c0402c59363956d0c4eefc1b8a059e1fcc8e4.camel@linux.ibm.com \
    --to=ajd@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexghiti@rivosinc.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nicholas@linux.ibm.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=sweettea-kernel@dorminy.me \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.