All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org, akpm@linux-foundation.org
Cc: dhowells@redhat.com, Tejun Heo <tj@kernel.org>,
	linux-am33-list@redhat.com, linux-kernel@vger.kernel.org,
	Akira Takeuchi <takeuchi.akr@jp.panasonic.com>,
	Mark Salter <msalter@redhat.com>
Subject: Re: [Linux-am33-list] [PATCH] workqueue: Fix alignment calculation in alloc_cwqs()
Date: Mon, 25 Oct 2010 22:38:47 +0100	[thread overview]
Message-ID: <3386.1288042727@redhat.com> (raw)
In-Reply-To: <20101025212706.27798.23957.stgit@warthog.procyon.org.uk>

David Howells <dhowells@redhat.com> wrote:

> +	const size_t align =
> +		max_t(size_t, 1 << (WORK_STRUCT_FLAG_BITS - BITS_PER_BYTE),
> +		      __alignof__(unsigned long long));

Actually, no, that's not right either.  Need to subtract log2(BITS_PER_BYTE).

David

  reply	other threads:[~2010-10-25 21:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-25 21:27 [PATCH] workqueue: Fix alignment calculation in alloc_cwqs() David Howells
2010-10-25 21:38 ` David Howells [this message]
2010-10-25 21:43 ` Linus Torvalds
2010-10-25 21:46   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3386.1288042727@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-am33-list@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msalter@redhat.com \
    --cc=takeuchi.akr@jp.panasonic.com \
    --cc=tj@kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.