From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, akpm@linux-foundation.org,
Tejun Heo <tj@kernel.org>,
linux-am33-list@redhat.com, linux-kernel@vger.kernel.org,
Akira Takeuchi <takeuchi.akr@jp.panasonic.com>,
Mark Salter <msalter@redhat.com>
Subject: Re: [PATCH] workqueue: Fix alignment calculation in alloc_cwqs()
Date: Mon, 25 Oct 2010 22:46:53 +0100 [thread overview]
Message-ID: <3487.1288043213@redhat.com> (raw)
In-Reply-To: <AANLkTi=_siOR8QtXdW07ZY1mFG9_A2806erd64cRNRCb@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> No it doesn't. Those bits really require that many bytes of alignment.
>
> Think about it: if the low 8 bits of the pointer are used for flags,
> then the actual pointer itself needs to be aligned to a 256-byte
> boundary.
>
> So the code is right. If needs to ask for "1 << WORK_STRUCT_FLAG_BITS"
> alignment, and if it doesn't get it (because the allocator is somehow
> broken - percpu allocator issues?), things will break.
That's a good point.
David
prev parent reply other threads:[~2010-10-25 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 21:27 [PATCH] workqueue: Fix alignment calculation in alloc_cwqs() David Howells
2010-10-25 21:38 ` [Linux-am33-list] " David Howells
2010-10-25 21:43 ` Linus Torvalds
2010-10-25 21:46 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3487.1288043213@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=takeuchi.akr@jp.panasonic.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.