[dpdk-dev] [PATCH v1 0/2] add travis ci support for ppc64le

[dpdk-dev] [PATCH v1 0/2] add travis ci support for ppc64le

[David Wilder]

This patch series adds Travis gcc compilation jobs for ppc64le.
Limitations for ppc64le are similar to arm64 (see commit
31bb45bcfd).

1. Only gcc builds are supported on ppc64le.

2. A container is used, therefor Huge pages are not available.
   Unit tests are not run, a single test (test-null) using the
   no-huge option is run.

The first patch in the series adjusts parameters for devtools/test-null.sh
as required for ppc64le.

A Travis build with theses two patches can be found here:
https://travis-ci.org/djlwilder/dpdk/builds/650091701

David Wilder (2):
  devtools: allow test-null.sh to run on ppc64le
  ci: add travis ci support for native ppc64le

 .travis.yml           | 29 +++++++++++++++++++++++++++++
 devtools/test-null.sh |  2 +-
 2 files changed, 30 insertions(+), 1 deletion(-)

-- 
2.25.0

[dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le

[David Wilder]

- Memory requirements are larger for ppc64le
  due to a higher RTE_MAX_LCORE value.

- The --no-huge option requires iova-mode=VA.
  On ppc64le iova-mode defaults to PA therefor
  VA mode must be explicitly set.

Signed-off-by: David Wilder <dwilder@us.ibm.com>
Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
---
 devtools/test-null.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/test-null.sh b/devtools/test-null.sh
index 548de8113..85952d1dc 100755
--- a/devtools/test-null.sh
+++ b/devtools/test-null.sh
@@ -27,6 +27,6 @@ else
 fi
 
 (sleep 1 && echo stop) |
-$testpmd -c $coremask --no-huge -m 20 \
+$testpmd -c $coremask --no-huge -m 30 --iova-mode=va \
 	$libs -w 0:0.0 --vdev net_null1 --vdev net_null2 $eal_options -- \
 	--no-mlockall --total-num-mbufs=2048 $testpmd_options -ia
-- 
2.25.0

Re: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le

[Thomas Monjalon]

13/02/2020 21:24, David Wilder:
> - The --no-huge option requires iova-mode=VA.
>   On ppc64le iova-mode defaults to PA therefor
>   VA mode must be explicitly set.

Should we make VA mode automatic when using --no-huge?
Should we log an error message when using --no-huge with PA mode?

Re: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le

[dwilder]

On 2020-02-13 12:32, Thomas Monjalon wrote:
> 13/02/2020 21:24, David Wilder:
>> - The --no-huge option requires iova-mode=VA.
>>   On ppc64le iova-mode defaults to PA therefor
>>   VA mode must be explicitly set.
> 
> Should we make VA mode automatic when using --no-huge?
> Should we log an error message when using --no-huge with PA mode?

Logging a messages sounds like a good idea.  Ignoring the users request 
of iova-mode=PA (in the case of x86) and just switching modes would be 
bad.

Re: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le

[Thomas Monjalon]

13/02/2020 21:58, dwilder:
> On 2020-02-13 12:32, Thomas Monjalon wrote:
> > 13/02/2020 21:24, David Wilder:
> >> - The --no-huge option requires iova-mode=VA.
> >>   On ppc64le iova-mode defaults to PA therefor
> >>   VA mode must be explicitly set.
> > 
> > Should we make VA mode automatic when using --no-huge?
> > Should we log an error message when using --no-huge with PA mode?
> 
> Logging a messages sounds like a good idea.  Ignoring the users request 
> of iova-mode=PA (in the case of x86) and just switching modes would be 
> bad.

Yes, I mean for ppc64, if --no-huge is specified,
would you like to change the default to VA mode?

Re: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le

[dwilder]

On 2020-02-13 14:17, Thomas Monjalon wrote:
> 13/02/2020 21:58, dwilder:
>> On 2020-02-13 12:32, Thomas Monjalon wrote:
>> > 13/02/2020 21:24, David Wilder:
>> >> - The --no-huge option requires iova-mode=VA.
>> >>   On ppc64le iova-mode defaults to PA therefor
>> >>   VA mode must be explicitly set.
>> >
>> > Should we make VA mode automatic when using --no-huge?
>> > Should we log an error message when using --no-huge with PA mode?
>> 
>> Logging a messages sounds like a good idea.  Ignoring the users 
>> request
>> of iova-mode=PA (in the case of x86) and just switching modes would be
>> bad.
> 
> Yes, I mean for ppc64, if --no-huge is specified,
> would you like to change the default to VA mode?

OK, that would be better.
I will switch to VA when --no-huge is set (ppc64 only).
Add log messages if PA is selected with --no-huge (all arches).

Re: [dpdk-dev] [PATCH v1 1/2] devtools: allow test-null.sh to run on ppc64le

[David Marchand]

On Fri, Feb 14, 2020 at 12:22 AM dwilder <dwilder@us.ibm.com> wrote:
>
> On 2020-02-13 14:17, Thomas Monjalon wrote:
> > 13/02/2020 21:58, dwilder:
> >> On 2020-02-13 12:32, Thomas Monjalon wrote:
> >> > 13/02/2020 21:24, David Wilder:
> >> >> - The --no-huge option requires iova-mode=VA.
> >> >>   On ppc64le iova-mode defaults to PA therefor
> >> >>   VA mode must be explicitly set.
> >> >
> >> > Should we make VA mode automatic when using --no-huge?
> >> > Should we log an error message when using --no-huge with PA mode?
> >>
> >> Logging a messages sounds like a good idea.  Ignoring the users
> >> request
> >> of iova-mode=PA (in the case of x86) and just switching modes would be
> >> bad.
> >
> > Yes, I mean for ppc64, if --no-huge is specified,
> > would you like to change the default to VA mode?
>
> OK, that would be better.
> I will switch to VA when --no-huge is set (ppc64 only).

With no-huge, we can't ensure the physical addresses won't change
(might be different if we locked the pages in memory... but not
possible and/or not handled in eal afaics).
This limitation is generic, not arch specific.


> Add log messages if PA is selected with --no-huge (all arches).

-- 
David Marchand

[dpdk-dev] [PATCH v1 2/2] ci: add travis ci support for native ppc64le

[David Wilder]

This change follows the example of aarch64 Travis support
by adding support for ppc64le gcc builds.  Limitations for
ppc64le are the same as aarch64 as described in commit
31bb45bcfd.

Signed-off-by: David Wilder <dwilder@us.ibm.com>
Reviewed-by: David Christensen <drc@linux.vnet.ibm.com>
---
 .travis.yml | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 22539d823..1e95cbe57 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -167,5 +167,34 @@ matrix:
       apt:
         packages:
           - *extra_packages
+  - env: DEF_LIB="static"
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *required_packages
+  - env: DEF_LIB="shared"
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *required_packages
+  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" BUILD_DOCS=1
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *required_packages
+          - *doc_packages
+  - env: DEF_LIB="shared" EXTRA_PACKAGES=1 ABI_CHECKS=1
+    arch: ppc64le
+    compiler: gcc
+    addons:
+      apt:
+        packages:
+          - *extra_packages
 
 script: ./.ci/${TRAVIS_OS_NAME}-build.sh
-- 
2.25.0