All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Geliang Tang <geliangtang@gmail.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	David Airlie <airlied@linux.ie>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/radeon: use list_move in radeon_vm_bo_update
Date: Fri, 11 Nov 2016 14:46:51 +0100	[thread overview]
Message-ID: <3391741d-219d-d778-9d34-e050d8ea1f17@amd.com> (raw)
In-Reply-To: <a23f3507ba7bad3d94ca8683d9021f1f565ec6aa.1478858593.git.geliangtang@gmail.com>

Am 11.11.2016 um 13:26 schrieb Geliang Tang:
> Use list_move() instead of list_del() + list_add() to simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>

Reviewed-by: Christian König <christian.koenig@amd.com>.

> ---
>   drivers/gpu/drm/radeon/radeon_vm.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
> index a135874..2f1e372 100644
> --- a/drivers/gpu/drm/radeon/radeon_vm.c
> +++ b/drivers/gpu/drm/radeon/radeon_vm.c
> @@ -933,8 +933,7 @@ int radeon_vm_bo_update(struct radeon_device *rdev,
>   		}
>   		list_del_init(&bo_va->vm_status);
>   	} else {
> -		list_del(&bo_va->vm_status);
> -		list_add(&bo_va->vm_status, &vm->cleared);
> +		list_move(&bo_va->vm_status, &vm->cleared);
>   	}
>   	spin_unlock(&vm->status_lock);
>   


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Christian König" <christian.koenig@amd.com>
To: Geliang Tang <geliangtang@gmail.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	David Airlie <airlied@linux.ie>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/radeon: use list_move in radeon_vm_bo_update
Date: Fri, 11 Nov 2016 14:46:51 +0100	[thread overview]
Message-ID: <3391741d-219d-d778-9d34-e050d8ea1f17@amd.com> (raw)
In-Reply-To: <a23f3507ba7bad3d94ca8683d9021f1f565ec6aa.1478858593.git.geliangtang@gmail.com>

Am 11.11.2016 um 13:26 schrieb Geliang Tang:
> Use list_move() instead of list_del() + list_add() to simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>

Reviewed-by: Christian König <christian.koenig@amd.com>.

> ---
>   drivers/gpu/drm/radeon/radeon_vm.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c
> index a135874..2f1e372 100644
> --- a/drivers/gpu/drm/radeon/radeon_vm.c
> +++ b/drivers/gpu/drm/radeon/radeon_vm.c
> @@ -933,8 +933,7 @@ int radeon_vm_bo_update(struct radeon_device *rdev,
>   		}
>   		list_del_init(&bo_va->vm_status);
>   	} else {
> -		list_del(&bo_va->vm_status);
> -		list_add(&bo_va->vm_status, &vm->cleared);
> +		list_move(&bo_va->vm_status, &vm->cleared);
>   	}
>   	spin_unlock(&vm->status_lock);
>   

  parent reply	other threads:[~2016-11-11 13:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11 12:26 [PATCH] drm/radeon: use list_move in radeon_vm_bo_update Geliang Tang
2016-11-11 12:26 ` [PATCH] HID: intel_ish-hid: use list_move_tail in ishtp_cl_read_start Geliang Tang
2016-11-11 22:51   ` Srinivas Pandruvada
2016-11-11 13:46 ` Christian König [this message]
2016-11-11 13:46   ` [PATCH] drm/radeon: use list_move in radeon_vm_bo_update Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3391741d-219d-d778-9d34-e050d8ea1f17@amd.com \
    --to=christian.koenig@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geliangtang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.