From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] eal: fix build
Date: Wed, 29 Jul 2015 18:05:31 +0200 [thread overview]
Message-ID: <3400596.gUZi4e9jS4@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8B7011@SHSMSX104.ccr.corp.intel.com>
2015-07-29 15:09, Zhang, Helin:
> From: Gonzalez Monroy, Sergio
> > Fixes: 4d4ebca4 ("pci: merge probing and closing functions for linux and bsd")
> >
> > The function rte_eal_pci_probe_one_driver, which calls pci_config_space_set,
> > was moved to eal_common_pci.c, but pci_config_space_set was left in eal_pci.c
> > with static specifier.
>
> Yes, that's the root cause.
> I am just have a thought that we may need to move all of those three functions
> together into eal_common_pci.c, which can avoid exporting that function.
No it is specific to Linux (implemented in igb_uio only).
But it may be moved to eal_common if you remove the igb_uio patch and use
the new functions to access to PCI config with UIO or VFIO:
http://dpdk.org/browse/dpdk/commit/?id=632b2d1deeed
This build fix will be applied for 2.1.
It is expected the above rework will be done for 2.2.
Thanks
next prev parent reply other threads:[~2015-07-29 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 22:48 [PATCH] eal: fix build Helin Zhang
2015-07-29 8:19 ` Thomas Monjalon
2015-07-29 15:00 ` Zhang, Helin
2015-07-29 15:05 ` Gonzalez Monroy, Sergio
2015-07-29 15:09 ` Zhang, Helin
2015-07-29 16:05 ` Thomas Monjalon [this message]
2015-07-29 16:10 ` Zhang, Helin
2015-07-29 15:08 ` Thomas Monjalon
2015-07-29 15:18 ` Zhang, Helin
2015-07-30 0:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3400596.gUZi4e9jS4@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.