All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: George Dunlap <George.Dunlap@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien@xen.org>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels"
Date: Fri, 5 Apr 2024 07:59:35 +0200	[thread overview]
Message-ID: <3419b5d6-ac57-4de4-a87d-c82577584fa8@suse.com> (raw)
In-Reply-To: <61945064-38ec-4ea5-9084-a82d3c252b2d@apertussolutions.com>

On 03.04.2024 15:27, Daniel P. Smith wrote:
> On 4/3/24 08:05, Jan Beulich wrote:
>> On 03.04.2024 13:10, Daniel P. Smith wrote:
>>> On 4/3/24 02:16, Jan Beulich wrote:
>>>> On 02.04.2024 19:06, Andrew Cooper wrote:
>>>>>    It is also quite
>>>>> obvious from XSM_TARGET that it has broken device model stubdoms too.
>>>>
>>>> Why would that be "obvious"? What business would a stubdom have to look at
>>>> Xen's side of an evtchn?
>>>
>>> Again, you have not expressed why it shouldn't be able to do so.
>>
>> See above - not its resource, nor its guest's.
> 
> It is a resource provided to a domain that the domain can send/raise an 
> event to and a backing domain that can bind to it, ie. the two 
> parameters that must be passed to the allocation call.

Before writing this particular part of your reply, did you look as
evtchn_send()? Sending on such ports is similarly denied without
involving XSM. For a good reason, stated in the accompanying comment.
It is therefore simply inconsistent to allow any kind of other
operation on such ports. Hence the patch that Andrew now deems needs
reverting.

In fact I view these ports living in the guest's event channel space
as similarly inappropriate as the ioreq pages - until a few years
back - living in the guest's GFN space.

Jan


  parent reply	other threads:[~2024-04-05  6:00 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 17:06 [PATCH] Revert "evtchn: refuse EVTCHNOP_status for Xen-bound event channels" Andrew Cooper
2024-04-03  6:16 ` Jan Beulich
2024-04-03  6:52   ` Jan Beulich
2024-04-03 11:50     ` Daniel P. Smith
2024-04-03 11:54       ` Jan Beulich
2024-04-03 13:31         ` Daniel P. Smith
2024-04-04  8:11           ` Jan Beulich
2024-04-03 11:10   ` Daniel P. Smith
2024-04-03 12:05     ` Jan Beulich
2024-04-03 13:27       ` Daniel P. Smith
2024-04-04  7:57         ` Jan Beulich
2024-04-05  5:59         ` Jan Beulich [this message]
2024-05-14  9:25   ` Jan Beulich
2024-05-14  9:51     ` Andrew Cooper
2024-05-14 10:03       ` Jan Beulich
2024-05-14 11:13         ` Julien Grall
2024-05-14 21:35           ` Stefano Stabellini
2024-05-15  7:33             ` Jan Beulich
2024-05-16 19:15           ` Oleksii K.
2024-05-17  7:01             ` Jan Beulich
2024-05-15 10:49       ` Kelly Choi
2024-05-15 12:59       ` George Dunlap
2024-05-16  6:41     ` Jan Beulich
2024-05-17  1:21       ` Stefano Stabellini
2024-05-17  7:04         ` Jan Beulich
2024-05-17 20:28           ` Stefano Stabellini
2024-05-21  6:17             ` Jan Beulich
2024-05-22  1:33               ` Stefano Stabellini
2024-05-17  1:22       ` Daniel P. Smith
2024-05-17  7:24         ` Jan Beulich
2024-04-03 13:35 ` Daniel P. Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3419b5d6-ac57-4de4-a87d-c82577584fa8@suse.com \
    --to=jbeulich@suse.com \
    --cc=George.Dunlap@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dpsmith@apertussolutions.com \
    --cc=julien@xen.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.