From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jaipaul Cheernam <jaipaul.cheernam@est.tech>,
bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH] parse: warn on trailing whitespace after line continuation backslash
Date: Tue, 04 Aug 2026 12:37:56 +0100 [thread overview]
Message-ID: <34211867d74a9757b5b0ff10e7ac3c0b4811ceda.camel@linuxfoundation.org> (raw)
In-Reply-To: <9a3bc50b-89a8-439c-aa44-1b2707a88ca4@est.tech>
On Tue, 2026-08-04 at 12:37 +0200, Jaipaul Cheernam wrote:
> Hi Richard,
>
> Fair point — it doesn't break parsing itself and the code churn is
> larger than ideal for a warning.
>
> Would you prefer if I just submitted the oe-core fixes to clean up
> the affected recipes instead and dropped this bitbake change? That
> solves the immediate problem without adding complexity to the parser.
You should definitely send that clean up for oe-core.
I was toying with the idea we just make whitespace after a line break
character a fatal parsing error. Most of the fatal errors are inside
feeder() rather than where you changed the code.
I then looked at the code further and it isn't just trailing whitespace
after "\" that is an issue. For example, after "}" closing a function
could also be an issue in the same way. I didn't look in detail beyond
that, there will be further similar issues though and that does mean
your patch is incomplete :/.
> Alternatively, I could reduce this to a bb.note() (debug-level) so
> it's only visible with -v, keeping it minimal.
I think this needs further thought and some wider testing of how
widespread trailing whitespace is.
We might just want to make any trailing spaces a warning since we
currently just swallow and hide it unconditionally?
Cheers,
Richard
next prev parent reply other threads:[~2026-08-04 11:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 9:08 [PATCH] parse: warn on trailing whitespace after line continuation backslash Jaipaul Cheernam
2026-08-04 10:27 ` [bitbake-devel] " Richard Purdie
2026-08-04 10:37 ` Jaipaul Cheernam
2026-08-04 11:37 ` Richard Purdie [this message]
2026-08-04 12:15 ` Jaipaul Cheernam
2026-08-06 10:44 ` [PATCH v2] parse: warn on trailing whitespace in parsed lines Jaipaul Cheernam
2026-08-06 11:24 ` Jaipaul Cheernam
2026-08-13 15:07 ` [bitbake-devel] " Mathieu Dubois-Briand
2026-08-13 16:54 ` Jaipaul Cheernam
2026-08-20 10:31 ` Jaipaul Cheernam
2026-08-23 8:14 ` [bitbake-devel] " Mathieu Dubois-Briand
2026-08-25 16:13 ` Jaipaul Cheernam
2026-08-26 14:34 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34211867d74a9757b5b0ff10e7ac3c0b4811ceda.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=jaipaul.cheernam@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.