All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: "Jaipaul Cheernam" <jaipaul.cheernam@est.tech>,
	<bitbake-devel@lists.openembedded.org>
Subject: Re: [bitbake-devel] [PATCH v2] parse: warn on trailing whitespace in parsed lines
Date: Thu, 13 Aug 2026 17:07:34 +0200	[thread overview]
Message-ID: <DKNWRTWPZT8T.1ZLGV8S99L5N9@bootlin.com> (raw)
In-Reply-To: <20260806112435.25128-1-jaipaul.cheernam@est.tech>

On Thu Aug 6, 2026 at 1:24 PM CEST, Jaipaul Cheernam wrote:
> rstrip() silently strips trailing whitespace before processing. This
> hides invisible spaces or tabs that end up in patch context and cause
> patches to fail to apply across branches.
>
> Warn on any line with trailing whitespace so developers can fix it early.
>
> Signed-off-by: Jaipaul Cheernam <jaipaul.cheernam@est.tech>
> ---

Hi Jaipaul,

Thanks for the v2. I forgot to ask: do you plan to provide an oe-core
patch fixing all whitespace issues? As so far, this is adding a lot of
warnings during the build:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/4/builds/4405

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2026-08-13 15:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  9:08 [PATCH] parse: warn on trailing whitespace after line continuation backslash Jaipaul Cheernam
2026-08-04 10:27 ` [bitbake-devel] " Richard Purdie
2026-08-04 10:37   ` Jaipaul Cheernam
2026-08-04 11:37     ` Richard Purdie
2026-08-04 12:15       ` Jaipaul Cheernam
2026-08-06 10:44 ` [PATCH v2] parse: warn on trailing whitespace in parsed lines Jaipaul Cheernam
2026-08-06 11:24 ` Jaipaul Cheernam
2026-08-13 15:07   ` Mathieu Dubois-Briand [this message]
2026-08-13 16:54     ` [bitbake-devel] " Jaipaul Cheernam
2026-08-20 10:31       ` Jaipaul Cheernam
2026-08-23  8:14         ` [bitbake-devel] " Mathieu Dubois-Briand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DKNWRTWPZT8T.1ZLGV8S99L5N9@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=jaipaul.cheernam@est.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.