* [PATCH BLUEZ] android/pan: Fix not NULL terminating parsed string
@ 2015-07-29 6:24 Dohyun Pyun
2015-07-29 7:29 ` Szymon Janc
0 siblings, 1 reply; 2+ messages in thread
From: Dohyun Pyun @ 2015-07-29 6:24 UTC (permalink / raw)
To: linux-bluetooth, szymon.janc; +Cc: steve.jun, DoHyun Pyun
From: DoHyun Pyun <dh79.pyun@samsung.com>
This patch prevents the possible not NULL terminating problem.
ifr_name's array size is IFNAMSIZ. So If BNEP_BRIDGE has IFNAMSIZ size,
the name string will be not NULL terminating.
---
android/pan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/android/pan.c b/android/pan.c
index 0bb576e..c40a6d3 100644
--- a/android/pan.c
+++ b/android/pan.c
@@ -88,7 +88,7 @@ static int set_forward_delay(int sk)
struct ifreq ifr;
memset(&ifr, 0, sizeof(ifr));
- strncpy(ifr.ifr_name, BNEP_BRIDGE, IFNAMSIZ);
+ strncpy(ifr.ifr_name, BNEP_BRIDGE, IFNAMSIZ - 1);
ifr.ifr_data = (char *) args;
if (ioctl(sk, SIOCDEVPRIVATE, &ifr) < 0) {
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH BLUEZ] android/pan: Fix not NULL terminating parsed string
2015-07-29 6:24 [PATCH BLUEZ] android/pan: Fix not NULL terminating parsed string Dohyun Pyun
@ 2015-07-29 7:29 ` Szymon Janc
0 siblings, 0 replies; 2+ messages in thread
From: Szymon Janc @ 2015-07-29 7:29 UTC (permalink / raw)
To: Dohyun Pyun; +Cc: linux-bluetooth, steve.jun
Hi Dohyun Pyun,
On Wednesday 29 of July 2015 15:24:48 Dohyun Pyun wrote:
> From: DoHyun Pyun <dh79.pyun@samsung.com>
>
> This patch prevents the possible not NULL terminating problem.
> ifr_name's array size is IFNAMSIZ. So If BNEP_BRIDGE has IFNAMSIZ size,
> the name string will be not NULL terminating.
> ---
> android/pan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/pan.c b/android/pan.c
> index 0bb576e..c40a6d3 100644
> --- a/android/pan.c
> +++ b/android/pan.c
> @@ -88,7 +88,7 @@ static int set_forward_delay(int sk)
> struct ifreq ifr;
>
> memset(&ifr, 0, sizeof(ifr));
> - strncpy(ifr.ifr_name, BNEP_BRIDGE, IFNAMSIZ);
> + strncpy(ifr.ifr_name, BNEP_BRIDGE, IFNAMSIZ - 1);
> ifr.ifr_data = (char *) args;
>
> if (ioctl(sk, SIOCDEVPRIVATE, &ifr) < 0) {
Patch applied, thanks.
--
BR
Szymon Janc
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-29 7:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-29 6:24 [PATCH BLUEZ] android/pan: Fix not NULL terminating parsed string Dohyun Pyun
2015-07-29 7:29 ` Szymon Janc
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.