All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Chen-Yu Tsai <wens@csie.org>,
	Samuel Holland <samuel@sholland.org>,
	Mans Rullgard <mans@mansr.com>,
	Maxime Ripard <mripard@kernel.org>,
	Jinjie Ruan <ruanjinjie@huawei.com>
Cc: ruanjinjie@huawei.com
Subject: Re: [PATCH -next] clocksource/drivers/sun5i: Remove redundant dev_err() for platform_get_irq()
Date: Tue, 05 Sep 2023 22:33:36 +0200	[thread overview]
Message-ID: <3440176.QJadu78ljV@archlinux> (raw)
In-Reply-To: <20230901071328.1322235-1-ruanjinjie@huawei.com>

On Friday, September 1, 2023 9:13:28 AM CEST Jinjie Ruan wrote:
> Since commit 7723f4c5ecdb ("driver core: platform: Add an error message
> to platform_get_irq*()") and commit 2043727c2882 ("driver core:
> platform: Make use of the helper function dev_err_probe()"), there is
> no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as it is
> going to display an appropriate error message in case of a failure.
> 
> Fixes: 7e5bac610d2f ("clocksource/drivers/sun5i: Convert to platform device
> driver") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>

This was already submitted one day earlier:
https://lore.kernel.org/all/20230831041414.66434-1-yang.lee@linux.alibaba.com/

Best regards,
Jernej

> ---
>  drivers/clocksource/timer-sun5i.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-sun5i.c
> b/drivers/clocksource/timer-sun5i.c index 69fee3540d37..0d229a9058da 100644
> --- a/drivers/clocksource/timer-sun5i.c
> +++ b/drivers/clocksource/timer-sun5i.c
> @@ -256,10 +256,8 @@ static int sun5i_timer_probe(struct platform_device
> *pdev) }
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "Can't get IRQ\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> 
>  	clk = devm_clk_get_enabled(dev, NULL);
>  	if (IS_ERR(clk)) {





WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Chen-Yu Tsai <wens@csie.org>,
	Samuel Holland <samuel@sholland.org>,
	Mans Rullgard <mans@mansr.com>,
	Maxime Ripard <mripard@kernel.org>,
	Jinjie Ruan <ruanjinjie@huawei.com>
Cc: ruanjinjie@huawei.com
Subject: Re: [PATCH -next] clocksource/drivers/sun5i: Remove redundant dev_err() for platform_get_irq()
Date: Tue, 05 Sep 2023 22:33:36 +0200	[thread overview]
Message-ID: <3440176.QJadu78ljV@archlinux> (raw)
In-Reply-To: <20230901071328.1322235-1-ruanjinjie@huawei.com>

On Friday, September 1, 2023 9:13:28 AM CEST Jinjie Ruan wrote:
> Since commit 7723f4c5ecdb ("driver core: platform: Add an error message
> to platform_get_irq*()") and commit 2043727c2882 ("driver core:
> platform: Make use of the helper function dev_err_probe()"), there is
> no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as it is
> going to display an appropriate error message in case of a failure.
> 
> Fixes: 7e5bac610d2f ("clocksource/drivers/sun5i: Convert to platform device
> driver") Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>

This was already submitted one day earlier:
https://lore.kernel.org/all/20230831041414.66434-1-yang.lee@linux.alibaba.com/

Best regards,
Jernej

> ---
>  drivers/clocksource/timer-sun5i.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/clocksource/timer-sun5i.c
> b/drivers/clocksource/timer-sun5i.c index 69fee3540d37..0d229a9058da 100644
> --- a/drivers/clocksource/timer-sun5i.c
> +++ b/drivers/clocksource/timer-sun5i.c
> @@ -256,10 +256,8 @@ static int sun5i_timer_probe(struct platform_device
> *pdev) }
> 
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "Can't get IRQ\n");
> +	if (irq < 0)
>  		return irq;
> -	}
> 
>  	clk = devm_clk_get_enabled(dev, NULL);
>  	if (IS_ERR(clk)) {





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-05 20:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01  7:13 [PATCH -next] clocksource/drivers/sun5i: Remove redundant dev_err() for platform_get_irq() Jinjie Ruan
2023-09-01  7:13 ` Jinjie Ruan
2023-09-05 20:33 ` Jernej Škrabec [this message]
2023-09-05 20:33   ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3440176.QJadu78ljV@archlinux \
    --to=jernej.skrabec@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mans@mansr.com \
    --cc=mripard@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=samuel@sholland.org \
    --cc=tglx@linutronix.de \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.