All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER
@ 2026-01-15 12:50 Maíra Canal
  2026-01-21 17:26 ` Nicolas Frattaroli
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Maíra Canal @ 2026-01-15 12:50 UTC (permalink / raw)
  To: Neil Armstrong, Jessica Zhang, Langyan Ye
  Cc: dri-devel, kernel-dev, Maíra Canal

The panel-ilitek-ili9882t driver uses drm_dsc_pps_payload_pack() which
is provided by the DRM_DISPLAY_DSC_HELPER. Add the missing Kconfig
select to fix the following build error:

  ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-ilitek-ili9882t.ko] undefined!

Fixes: 65ce1f5834e9 ("drm/panel: ilitek-ili9882t: Switch Tianma TL121BVMS07 to DSC 120Hz mode")
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index a0fe6069e5e4..ae25f003aa33 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -280,6 +280,7 @@ config DRM_PANEL_ILITEK_ILI9882T
 	depends on OF
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_DSC_HELPER
 	help
 	  Say Y if you want to enable support for panels based on the
 	  Ilitek ILI9882t controller.
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER
  2026-01-15 12:50 [PATCH] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER Maíra Canal
@ 2026-01-21 17:26 ` Nicolas Frattaroli
  2026-01-26  8:50 ` Neil Armstrong
  2026-01-26 12:42 ` Maíra Canal
  2 siblings, 0 replies; 7+ messages in thread
From: Nicolas Frattaroli @ 2026-01-21 17:26 UTC (permalink / raw)
  To: Neil Armstrong, Jessica Zhang, Langyan Ye, dri-devel,
	Maíra Canal
  Cc: dri-devel, kernel-dev, Maíra Canal

On Thursday, 15 January 2026 13:50:48 Central European Standard Time Maíra Canal wrote:
> The panel-ilitek-ili9882t driver uses drm_dsc_pps_payload_pack() which
> is provided by the DRM_DISPLAY_DSC_HELPER. Add the missing Kconfig
> select to fix the following build error:
> 
>   ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-ilitek-ili9882t.ko] undefined!
> 
> Fixes: 65ce1f5834e9 ("drm/panel: ilitek-ili9882t: Switch Tianma TL121BVMS07 to DSC 120Hz mode")
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>  drivers/gpu/drm/panel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index a0fe6069e5e4..ae25f003aa33 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -280,6 +280,7 @@ config DRM_PANEL_ILITEK_ILI9882T
>  	depends on OF
>  	depends on DRM_MIPI_DSI
>  	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_DSC_HELPER
>  	help
>  	  Say Y if you want to enable support for panels based on the
>  	  Ilitek ILI9882t controller.
> 

Tested-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

Thanks, this build failure has been annoying me for the past few days,
can confirm it works as described and the fix makes sense.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER
  2026-01-15 12:50 [PATCH] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER Maíra Canal
  2026-01-21 17:26 ` Nicolas Frattaroli
@ 2026-01-26  8:50 ` Neil Armstrong
  2026-01-26 12:42 ` Maíra Canal
  2 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2026-01-26  8:50 UTC (permalink / raw)
  To: Maíra Canal, Jessica Zhang, Langyan Ye; +Cc: dri-devel, kernel-dev

On 1/15/26 13:50, Maíra Canal wrote:
> The panel-ilitek-ili9882t driver uses drm_dsc_pps_payload_pack() which
> is provided by the DRM_DISPLAY_DSC_HELPER. Add the missing Kconfig
> select to fix the following build error:
> 
>    ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-ilitek-ili9882t.ko] undefined!
> 
> Fixes: 65ce1f5834e9 ("drm/panel: ilitek-ili9882t: Switch Tianma TL121BVMS07 to DSC 120Hz mode")
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
>   drivers/gpu/drm/panel/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index a0fe6069e5e4..ae25f003aa33 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -280,6 +280,7 @@ config DRM_PANEL_ILITEK_ILI9882T
>   	depends on OF
>   	depends on DRM_MIPI_DSI
>   	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_DSC_HELPER
>   	help
>   	  Say Y if you want to enable support for panels based on the
>   	  Ilitek ILI9882t controller.

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER
  2026-01-15 12:50 [PATCH] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER Maíra Canal
  2026-01-21 17:26 ` Nicolas Frattaroli
  2026-01-26  8:50 ` Neil Armstrong
@ 2026-01-26 12:42 ` Maíra Canal
  2026-01-26 14:09   ` Neil Armstrong
  2 siblings, 1 reply; 7+ messages in thread
From: Maíra Canal @ 2026-01-26 12:42 UTC (permalink / raw)
  To: Neil Armstrong, Jessica Zhang, Langyan Ye, Maíra Canal
  Cc: dri-devel, kernel-dev


On Thu, 15 Jan 2026 09:50:48 -0300, Maíra Canal wrote:
> The panel-ilitek-ili9882t driver uses drm_dsc_pps_payload_pack() which
> is provided by the DRM_DISPLAY_DSC_HELPER. Add the missing Kconfig
> select to fix the following build error:
> 
>   ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-ilitek-ili9882t.ko] undefined!
> 
> 
> [...]

Applied, thanks!

[1/1] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER
      commit: 68e28facbc8ab3e701e1814323d397a75b400865

Best regards,
- Maíra

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER
  2026-01-26 12:42 ` Maíra Canal
@ 2026-01-26 14:09   ` Neil Armstrong
  2026-01-26 14:23     ` Maíra Canal
  0 siblings, 1 reply; 7+ messages in thread
From: Neil Armstrong @ 2026-01-26 14:09 UTC (permalink / raw)
  To: Maíra Canal, Jessica Zhang, Langyan Ye; +Cc: dri-devel, kernel-dev

Hi,

On 1/26/26 13:42, Maíra Canal wrote:
> 
> On Thu, 15 Jan 2026 09:50:48 -0300, Maíra Canal wrote:
>> The panel-ilitek-ili9882t driver uses drm_dsc_pps_payload_pack() which
>> is provided by the DRM_DISPLAY_DSC_HELPER. Add the missing Kconfig
>> select to fix the following build error:
>>
>>    ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/panel-ilitek-ili9882t.ko] undefined!
>>
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER
>        commit: 68e28facbc8ab3e701e1814323d397a75b400865


You applied to the wrong branch, it's supposed to be applied to drm-misc-next-fixes after rc6

Neil

> 
> Best regards,
> - Maíra


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER
  2026-01-26 14:09   ` Neil Armstrong
@ 2026-01-26 14:23     ` Maíra Canal
  2026-01-26 14:29       ` Neil Armstrong
  0 siblings, 1 reply; 7+ messages in thread
From: Maíra Canal @ 2026-01-26 14:23 UTC (permalink / raw)
  To: Neil Armstrong, Jessica Zhang, Langyan Ye; +Cc: dri-devel, kernel-dev

Hi Neil,

On 26/01/26 11:09, Neil Armstrong wrote:
> Hi,
> 
> On 1/26/26 13:42, Maíra Canal wrote:
>>
>> On Thu, 15 Jan 2026 09:50:48 -0300, Maíra Canal wrote:
>>> The panel-ilitek-ili9882t driver uses drm_dsc_pps_payload_pack() which
>>> is provided by the DRM_DISPLAY_DSC_HELPER. Add the missing Kconfig
>>> select to fix the following build error:
>>>
>>>    ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/ 
>>> panel-ilitek-ili9882t.ko] undefined!
>>>
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/1] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER
>>        commit: 68e28facbc8ab3e701e1814323d397a75b400865
> 
> 
> You applied to the wrong branch, it's supposed to be applied to drm- 
> misc-next-fixes after rc6
> 

Before applying to drm-misc-next, I tried to apply to drm-misc-next-
fixes, but the patch didn't apply to that branch (65ce1f5834e9 is not
there yet). With that, I decided to apply to drm-misc-next.

Best regards,
- Maíra

> Neil
> 
>>
>> Best regards,
>> - Maíra
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER
  2026-01-26 14:23     ` Maíra Canal
@ 2026-01-26 14:29       ` Neil Armstrong
  0 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2026-01-26 14:29 UTC (permalink / raw)
  To: Maíra Canal, Jessica Zhang, Langyan Ye, Maxime Ripard,
	Thomas Zimmermann
  Cc: dri-devel, kernel-dev

On 1/26/26 15:23, Maíra Canal wrote:
> Hi Neil,
> 
> On 26/01/26 11:09, Neil Armstrong wrote:
>> Hi,
>>
>> On 1/26/26 13:42, Maíra Canal wrote:
>>>
>>> On Thu, 15 Jan 2026 09:50:48 -0300, Maíra Canal wrote:
>>>> The panel-ilitek-ili9882t driver uses drm_dsc_pps_payload_pack() which
>>>> is provided by the DRM_DISPLAY_DSC_HELPER. Add the missing Kconfig
>>>> select to fix the following build error:
>>>>
>>>>    ERROR: modpost: "drm_dsc_pps_payload_pack" [drivers/gpu/drm/panel/ panel-ilitek-ili9882t.ko] undefined!
>>>>
>>>>
>>>> [...]
>>>
>>> Applied, thanks!
>>>
>>> [1/1] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER
>>>        commit: 68e28facbc8ab3e701e1814323d397a75b400865
>>
>>
>> You applied to the wrong branch, it's supposed to be applied to drm- misc-next-fixes after rc6
>>
> 
> Before applying to drm-misc-next, I tried to apply to drm-misc-next-
> fixes, but the patch didn't apply to that branch (65ce1f5834e9 is not
> there yet). With that, I decided to apply to drm-misc-next.

Please ask before and let me apply the changes, now the patch will be applied for v6.21...
when asked, the drm-misc maintainers would prepare the drm- misc-next-fixes for use to apply.

@maxime, thomas, what the right step now ?

Neil

> 
> Best regards,
> - Maíra
> 
>> Neil
>>
>>>
>>> Best regards,
>>> - Maíra
>>
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-01-26 14:29 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-15 12:50 [PATCH] drm/panel: ilitek-ili9882t: Select DRM_DISPLAY_DSC_HELPER Maíra Canal
2026-01-21 17:26 ` Nicolas Frattaroli
2026-01-26  8:50 ` Neil Armstrong
2026-01-26 12:42 ` Maíra Canal
2026-01-26 14:09   ` Neil Armstrong
2026-01-26 14:23     ` Maíra Canal
2026-01-26 14:29       ` Neil Armstrong

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.