Re: [PATCH v6 00/15] Support 10-bit YUV422 and 8/10-bit YUV420 color format on DW HDMI QP

From: "Heiko Stübner" <heiko@sntech.de>
To: Daniel Stone <daniel@fooishbar.org>,
	Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Sandy Huang <hjc@rock-chips.com>, Andy Yan <andyshrk@163.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Daniel Stone <daniels@collabora.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	 Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
	kernel@collabora.com, dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	Sashiko <sashiko-bot@kernel.org>,
	Igor Paunovic <royalnet026@gmail.com>,
	Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [PATCH v6 00/15] Support 10-bit YUV422 and 8/10-bit YUV420 color format on DW HDMI QP
Date: Thu, 05 Nov 2026 14:22:44 +0100	[thread overview]
Message-ID: <34506010.aRNtrjHk3s@diego> (raw)
In-Reply-To: <81fbb960-abde-44ea-82ab-3adc054da836@collabora.com>

Am Donnerstag, 5. November 2026, 14:04:25 Mitteleuropäische Normalzeit schrieb Cristian Ciocaltea:
> Hi Daniel,
> 
> On 11/5/26 2:25 PM, Daniel Stone wrote:
> > Hi Cristi,
> > 
> > On Thu, 5 Nov 2026 at 01:01, Cristian Ciocaltea
> > <cristian.ciocaltea@collabora.com> wrote:
> >> Changes in v6:
> >> - Added new vop2 patch "Disable core clocks before dropping runtime PM
> >>   reference" (Sashiko)
> >>
> >> Changes in v5:
> >> - Added new patch "drm/rockchip: dw_hdmi_qp: Do not mask error code in
> >>   atomic_check()" to fix a pre-existing issue reported by Sashiko
> >>
> >> Changes in v3:
> >> - Updated patch 3 to skip any hardware programming in the callbacks
> >>   gated by drm_atomic_helper_commit_planes() after powering down VOP2 on
> >>   an atomic_enable() error (Sashiko)
> >> - Ensured VBLANK events are sent immediately when atomic_enable() fails,
> >>   hence preventing userspace processes waiting for the page flip
> >>   completion to hang indefinitely (new patch 4, Sashiko)
> >>
> >> Changes in v2:
> >> - Addressed several issues reported by Sashiko
> >>   * Reset AXI before detaching the IOMMU domain, to close a theoretical
> >>     window where stale or in-flight DMA transactions could fault or
> >>     access memory untranslated after the domain is detached (patch 6)
> >>   * Fixed resource leak on vop2_enable() error path (new patch 2)
> >>   * Balance state on atomic_enable error paths (new patch 3)
> >>   * Avoided division by zero when computing max_dclk (new path 4)
> >>   * Fixed VOP2_MAX_DCLK_RATE overflow on 32-bit (new patch 5)
> > 
> > I think everything in here should now be solidly reviewed. 
> 
> Thanks a lot for checking this out!

except patch 9 of 15, or mail hasn't turned up yet :-)

It does look fine to me, but if someone has an eye to spare ...

Heiko