From: Christian Lamparter <chunkeey@gmail.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
David Brown <david.brown@linaro.org>,
Sven Eckelmann <sven.eckelmann@openmesh.com>,
Andy Gross <andy.gross@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: msm: fix gpio-hog related boot issues
Date: Thu, 29 Mar 2018 16:05:47 +0200 [thread overview]
Message-ID: <3460672.7sj45fLQN6@debian64> (raw)
In-Reply-To: <5240033.8XEdSWCWGL@debian64>
On Thu 29 Mar 2018 14:23:35 CEST Christian Lamparter wrote:
> Ok I see, I was aware of ACPI but not that a pinctrl-msm based driver is
> using it. Well, I thinks is possible to use is_acpi_device_node() or
> !is_of_node() to detect whenever we are dealing with a OF or not:
>
> would it be ok to do something like this?
>
> | if (!is_of_node(chip->of_node)) {
oops, this should be:
if (!is_of_node(pctrl->dev->fwnode)) {
> | /*
> | * (lengthy note about gpiochip_add_pin_range and OF with
> | * reference to Documentation/devicetree/bindings/gpio/gpio.txt
> | * - TBD)
> | */
> | ret = gpiochip_add_pin_range(&pctrl->chip,
> | [...]
> | }
WARNING: multiple messages have this Message-ID (diff)
From: chunkeey@gmail.com (Christian Lamparter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: msm: fix gpio-hog related boot issues
Date: Thu, 29 Mar 2018 16:05:47 +0200 [thread overview]
Message-ID: <3460672.7sj45fLQN6@debian64> (raw)
In-Reply-To: <5240033.8XEdSWCWGL@debian64>
On Thu 29 Mar 2018 14:23:35 CEST Christian Lamparter wrote:
> Ok I see, I was aware of ACPI but not that a pinctrl-msm based driver is
> using it. Well, I thinks is possible to use is_acpi_device_node() or
> !is_of_node() to detect whenever we are dealing with a OF or not:
>
> would it be ok to do something like this?
>
> | if (!is_of_node(chip->of_node)) {
oops, this should be:
if (!is_of_node(pctrl->dev->fwnode)) {
> | /*
> | * (lengthy note about gpiochip_add_pin_range and OF with
> | * reference to Documentation/devicetree/bindings/gpio/gpio.txt
> | * - TBD)
> | */
> | ret = gpiochip_add_pin_range(&pctrl->chip,
> | [...]
> | }
next prev parent reply other threads:[~2018-03-29 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 18:07 [PATCH] pinctrl: msm: fix gpio-hog related boot issues Christian Lamparter
2018-03-28 18:07 ` Christian Lamparter
2018-03-29 0:27 ` Bjorn Andersson
2018-03-29 0:27 ` Bjorn Andersson
2018-03-29 12:23 ` Christian Lamparter
2018-03-29 12:23 ` Christian Lamparter
2018-03-29 14:05 ` Christian Lamparter [this message]
2018-03-29 14:05 ` Christian Lamparter
2018-04-12 12:48 ` Linus Walleij
2018-04-12 12:48 ` Linus Walleij
2018-04-12 19:05 ` Christian Lamparter
2018-04-12 19:05 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3460672.7sj45fLQN6@debian64 \
--to=chunkeey@gmail.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=sven.eckelmann@openmesh.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.