All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Jan-Philipp Litza <janphilipp@litza.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH] alfred: Tighten size check on received packet
Date: Fri, 23 Jan 2015 17:32:02 +0100	[thread overview]
Message-ID: <3471179.FAUhTczCdE@prime> (raw)
In-Reply-To: <1421705011.612946.10937.nullmailer@sylar.jplitza.de>

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

On Monday 19 January 2015 21:59:32 Jan-Philipp Litza wrote:
> When first checking if a received packet is truncated, the size of the
> alfred_tlv structure is ignored, thus allowing packets that are
> truncated by 4 bytes or less to pass the check unnoticed.
> 
> Even the check itself might access memory after the packet if its size
> was only 2 bytes or less.
> 
> Signed-off-by: Jan-Philipp Litza <janphilipp@litza.de>

applied in commit 0e2728c.

Thanks!
    Simon

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      parent reply	other threads:[~2015-01-23 16:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 20:59 [B.A.T.M.A.N.] [PATCH] alfred: Tighten size check on received packet Jan-Philipp Litza
2015-01-20  7:31 ` Sven Eckelmann
2015-01-20  8:01   ` Jan-Philipp Litza
2015-01-20  8:28     ` Sven Eckelmann
2015-01-23 16:32 ` Simon Wunderlich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3471179.FAUhTczCdE@prime \
    --to=sw@simonwunderlich.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=janphilipp@litza.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.