From: Sven Eckelmann <sven@narfation.org>
To: Jan-Philipp Litza <janphilipp@litza.de>
Cc: "'b.a.t.m.a.n@lists.open-mesh.org'" <b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] alfred: Tighten size check on received packet
Date: Tue, 20 Jan 2015 09:28:44 +0100 [thread overview]
Message-ID: <8724280.PKxsr8UKjR@bentobox> (raw)
In-Reply-To: <54BE0B72.1070502@litza.de>
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
On Tuesday 20 January 2015 09:01:54 Jan-Philipp Litza wrote:
> It already does that in the first line of the if statement. Your
> modification only checks this earlier, but because no data from the
> packet is accessed before the length check, it should not matter when we
> do this. Or am I missing the point?
Sorry, only looked with one eye at the patch when I came in this morning. So I
missed the first line.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-01-20 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 20:59 [B.A.T.M.A.N.] [PATCH] alfred: Tighten size check on received packet Jan-Philipp Litza
2015-01-20 7:31 ` Sven Eckelmann
2015-01-20 8:01 ` Jan-Philipp Litza
2015-01-20 8:28 ` Sven Eckelmann [this message]
2015-01-23 16:32 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8724280.PKxsr8UKjR@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=janphilipp@litza.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.