All of lore.kernel.org
 help / color / mirror / Atom feed
* [linux-lvm] another nice feature for packagers ...
@ 2001-06-17 13:38 Gergely Tamas
  2001-06-18 14:55 ` [linux-lvm] " AJ Lewis
  0 siblings, 1 reply; 12+ messages in thread
From: Gergely Tamas @ 2001-06-17 13:38 UTC (permalink / raw)
  To: linux-lvm; +Cc: AJ Lewis

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2937 bytes --]

Hi!

First of all, thanks for the ${DESTDIR} definition.

Another nice feature for packagers would be to split the installation of
liblvm.a and liblvm.so parts.

This would be good because liblvm.a's destination should be e.g. /usr/lib
and liblvm.so's destination should be /lib (because of lvm utils).

So I thought about the introduction of a new variable in make.tmpl.in (I
called it ``sharedlibdir''). Its default value is equal to ``libdir''.

So if somebody installs the package with ``make install'' or ``make -e
DESTDIR=... install'' the installation procedure will be the same as the
current. But if the installer (script) defines a sharedlibdir value other
than the default ``make -e sharedlibdir=... DESTDIR=... install'' the
installation of the shared libraries will go into that directory.

Note, that sharedlibdir needs to be specified with the DESTDIR value e.g.
``make -e sharedlibdir=$DESTDIR/$CPID/lib DESTDIR=$DESTDIR/$CPID install''

If you like this feature please include ...

Thanks,
Gergely

ps: I also attached my compile/package script; maybe somebody is
    interested in it...

diff -ur LVM-orig/make.tmpl.in LVM/make.tmpl.in
--- LVM-orig/make.tmpl.in	Fri Jun 15 16:16:02 2001
+++ LVM/make.tmpl.in	Sun Jun 17 12:45:36 2001
@@ -37,6 +37,7 @@
 exec_prefix = @exec_prefix@
 bindir = ${DESTDIR}/@bindir@
 libdir = ${DESTDIR}/@libdir@
+sharedlibdir = ${libdir}
 sbindir = ${DESTDIR}/@sbindir@
 infodir = ${DESTDIR}/@infodir@
 mandir = ${DESTDIR}/@mandir@
diff -ur LVM-orig/tools/lib/Makefile.in LVM/tools/lib/Makefile.in
--- LVM-orig/tools/lib/Makefile.in	Tue Apr 24 16:29:21 2001
+++ LVM/tools/lib/Makefile.in	Sun Jun 17 12:48:41 2001
@@ -44,18 +44,24 @@
 	@echo ""

 install_this:
-	@echo "*** Installing $(ARCHIVE) and $(SO) in ${prefix}/lib ***"
-	@rm -f ${libdir}/${SO} ${libdir}/${SOV} ${libdir}/${SOM} ${libdir}/$(ARCHIVE);
+	@echo "*** Installing $(ARCHIVE) in ${libdir} ***"
+	@rm -f ${libdir}/$(ARCHIVE);
 	@INSTALL@ -d ${libdir}
-	@INSTALL@ -o ${OWNER} -g ${GROUP} $(ARCHIVE) $(SOV) ${libdir}
+	@INSTALL@ -o ${OWNER} -g ${GROUP} $(ARCHIVE) ${libdir}
 	chmod 444 ${libdir}/$(ARCHIVE)
-	chmod 555 ${libdir}/$(SOV)
-	ln -s $(SOV) ${libdir}/${SO}
-	ln -s $(SOV) ${libdir}/${SOM}
+	@echo "*** Installing $(SO) in ${sharedlibdir} ***"
+	@rm -f ${sharedlibdir}/${SO} ${sharedlibdir}/${SOV} ${sharedlibdir}/${SOM};
+	@INSTALL@ -d ${sharedlibdir}
+	@INSTALL@ -o ${OWNER} -g ${GROUP} $(SOV) ${sharedlibdir}
+	chmod 555 ${sharedlibdir}/$(SOV)
+	ln -s $(SOV) ${sharedlibdir}/${SO}
+	ln -s $(SOV) ${sharedlibdir}/${SOM}

 remove_this:
-	@echo "*** Removing $(ARCHIVE) and $(SO) in ${prefix}/lib ***"
-	@rm -f ${libdir}/${SO} ${libdir}/${SOV} ${libdir}/${SOM} ${libdir}/$(ARCHIVE);
+	@echo "*** Removing $(ARCHIVE) in ${libdir} ***"
+	@rm -f ${libdir}/$(ARCHIVE);
+	@echo "*** Removing $(SO) in ${sharedlibdir} ***"
+	@rm -f ${libdir}/${SO} ${libdir}/${SOV} ${libdir}/${SOM};

 $(ALL_SOURCES):	liblvm.h $(OTHER_DEP)


[-- Attachment #2: Type: TEXT/PLAIN, Size: 1728 bytes --]

#!/bin/sh

# == generated by mkskel 0.0.2r19, (c) 2001 by DiCE/PsychoMix ==

DIRNAME="LVM";
PREFIX="/usr";
DESTDIR="/tmp/pkg";
BINTST="tools/vgchange";

AUTORUN=false;

error () { echo $1; exit 1; }

if [ ! -d $DIRNAME ];
then
  gzip -dc lvm-20010616.tar.gz | tar xvf -;
  $AUTORUN || exit;
fi

cd $DIRNAME;

if [ -f ../lvm-20010616.patch.bz2 ] && [ ! -f ../lvm-20010616.patched ];
then
  bzip2 -dc  ../lvm-20010616.patch.bz2 | patch -p1;
  touch ../lvm-20010616.patched;
  $AUTORUN || exit;
fi

if [ ! -f config.cache ] && [ -x ./configure ];
then
  touch config.cache;
  ./configure --prefix=$PREFIX \
              --sbindir=/sbin \
	      --libdir=$PREFIX/lib \
	      --includedir=$PREFIX/include \
	      --mandir=$PREFIX/man \
	      --infodir=$PREFIX/info
  $AUTORUN || exit;
fi

if [ ! -x $BINTST ];
then
  make;
  $AUTORUN || exit;
fi

if [ -f ../$0.temp ];
then
  CPID=`cat ../$0.temp`;
  [ ! -d $DESTDIR/$CPID ] && error "$DESTDIR/$CPID not found.";
else
  CPID=$$;
  if [ ! -d $DESTDIR/$CPID ];
  then
    mkdir -p $DESTDIR/$CPID;
    echo "$CPID" > ../$0.temp
    make -e sharedlibdir=$DESTDIR/$CPID/lib \
            DESTDIR=$DESTDIR/$CPID install 2>&1 | tee ../lvm-20010616.install_log;
    CPWD=`pwd`;
    cd $DESTDIR/$CPID;
    for i in `find . -type f | grep "/man/" | grep -v ".gz" | grep -v ".bz2"`;
    do
      MNAME=`basename $i`;
      echo "$MNAME -> $MNAME.gz";
      gzip $i;
    done
    cd $CPWD;
    $AUTORUN || exit;
  fi
fi

cd ..;

if  [ -d $DESTDIR/$CPID ];
then
  CPWD=`pwd`;
  cd $DESTDIR/$CPID;
  makepkg $CPWD/lvm-20010616.tgz;
  cd ..;
  rm -Rf $CPID;
  cd $CPWD;
fi

rm -f $0.temp lvm-20010616.patched;

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [linux-lvm] Re: another nice feature for packagers ...
@ 2001-06-18 16:09 Gergely Tamas
  2001-06-18 18:00 ` AJ Lewis
  0 siblings, 1 reply; 12+ messages in thread
From: Gergely Tamas @ 2001-06-18 16:09 UTC (permalink / raw)
  To: linux-lvm

Hi!

 > No problem, I'm still trying to decide if we should move ${DESTDIR} into the
 > individual 'install' targets or not...

Thats a good question. :) I tried your version, and it worked well. The
location of the configuration files is defived in a header file, so this
is not a problem. The static links worked also well...

 > Hmm...I think it should be the other way around.

Yes, I thought about this version too... It doesn't metter which one you
choose, as long as there are separate definitions for static and shared
libraries, I think. So they have not to be moved manually...

 > Just FYI, the entire build system is going to get an overhaul after the 1.0
 > release, so I will definitely be making sure these detail are kept in mind
 > for that.

Which will be released this wednesday as I can remember, right?

Thanks,
Gergely

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2001-07-06  0:47 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-06-17 13:38 [linux-lvm] another nice feature for packagers Gergely Tamas
2001-06-18 14:55 ` [linux-lvm] " AJ Lewis
2001-06-18 15:11   ` Steven Lembark
2001-06-18 15:31     ` AJ Lewis
2001-06-21  2:29       ` Steven Lembark
2001-06-21 14:28         ` AJ Lewis
2001-06-29  2:09   ` Mark van Walraven
     [not found]     ` <20010703131338.A23563@sistina.com>
     [not found]       ` <20010704124620.B7376@mail.wave.co.nz>
2001-07-05 12:00         ` AJ Lewis
2001-07-06  0:47           ` Mark van Walraven
  -- strict thread matches above, loose matches on Subject: below --
2001-06-18 16:09 Gergely Tamas
2001-06-18 18:00 ` AJ Lewis
2001-06-18 18:16   ` Gergely Tamas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.