All of lore.kernel.org
 help / color / mirror / Atom feed
From: Salil Mehta <salil.mehta@huawei.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
	"mst@redhat.com" <mst@redhat.com>,
	"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
	"Jonathan Cameron" <jonathan.cameron@huawei.com>,
	"alex.bennee@linaro.org" <alex.bennee@linaro.org>,
	"imammedo@redhat.com" <imammedo@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"gshan@redhat.com" <gshan@redhat.com>,
	"maz@kernel.org" <maz@kernel.org>,
	"will@kernel.org" <will@kernel.org>,
	"oliver.upton@linux.dev" <oliver.upton@linux.dev>,
	"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
	"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
	"david@redhat.com" <david@redhat.com>,
	"philmd@linaro.org" <philmd@linaro.org>,
	"andrew.jones@linux.dev" <andrew.jones@linux.dev>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>,
	"npiggin@gmail.com" <npiggin@gmail.com>,
	"harshpb@linux.ibm.com" <harshpb@linux.ibm.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"darren@os.amperecomputing.com" <darren@os.amperecomputing.com>,
	"ilkka@os.amperecomputing.com" <ilkka@os.amperecomputing.com>,
	"vishnu@os.amperecomputing.com" <vishnu@os.amperecomputing.com>,
	"karl.heubaum@oracle.com" <karl.heubaum@oracle.com>,
	"miguel.luis@oracle.com" <miguel.luis@oracle.com>,
	"salil.mehta@opnsrc.net" <salil.mehta@opnsrc.net>,
	zhukeqian <zhukeqian1@huawei.com>,
	"wangxiongfeng (C)" <wangxiongfeng2@huawei.com>,
	"wangyanan (Y)" <wangyanan55@huawei.com>,
	"jiakernel2@gmail.com" <jiakernel2@gmail.com>,
	"maobibo@loongson.cn" <maobibo@loongson.cn>,
	"lixianglai@loongson.cn" <lixianglai@loongson.cn>,
	"shahuang@redhat.com" <shahuang@redhat.com>,
	"zhao1.liu@intel.com" <zhao1.liu@intel.com>,
	Linuxarm <linuxarm@huawei.com>,
	"gustavo.romero@linaro.org" <gustavo.romero@linaro.org>
Subject: RE: [PATCH] arm/virt: Extract common code to wire GICC<->vCPU IRQs for reuse
Date: Wed, 6 Nov 2024 13:18:04 +0000	[thread overview]
Message-ID: <34aa0c9efb3144ab80a444144810b264@huawei.com> (raw)
In-Reply-To: <CAFEAcA9Jhz9a-X0B_bW++3kUePzTENJfq520A0CEst1o+QES4Q@mail.gmail.com>

HI Peter,

>  From: Peter Maydell <peter.maydell@linaro.org>
>  Sent: Wednesday, November 6, 2024 1:01 PM
>  To: Salil Mehta <salil.mehta@huawei.com>
>  
>  On Tue, 5 Nov 2024 at 22:20, Salil Mehta <salil.mehta@huawei.com> wrote:
>  >
>  > HI Peter,
>  >
>  > >  From: Peter Maydell <peter.maydell@linaro.org>
>  > >  Sent: Monday, November 4, 2024 1:27 PM
>  > >  To: Salil Mehta <salil.mehta@huawei.com>
>  > >
>  > >  On Sun, 3 Nov 2024 at 15:25, Salil Mehta <salil.mehta@huawei.com>
>  wrote:
>  > >  >
>  > >  > Extract common GIC and CPU interrupt wiring code to improve code
>  > > > readability and modularity, supporting reuse in future patch sets.
>  > >  > This refactor is benign and introduces *no* functional changes.
>  > >  >
>  > >  > Note: This patch has been isolated from a larger patch set to  >
>  > > facilitate early merging and reduce the complexity of the original
>  > > > set, as it operates independently. All original tags and author  >
>  > > contributions are retained.
>  > >
>  > >  I would prefer to see refactoring patches in the context of the
>  > > series that  makes them necessary. As it stands, there doesn't
>  > > really seem to be much  benefit to this change.
>  >
>  >
>  > Ok no issues. Just to confirm, your above comment is just specific to
>  > this patch or all the 3 individual patches I had sent for review?
>  
>  It applies to all of them (and as a general principle).


Got it. I thought changes in below patches were in any case useful as they were
improving the code?

https://lore.kernel.org/qemu-devel/20241103152256.202444-1-salil.mehta@huawei.com/
https://lore.kernel.org/qemu-devel/20241103152639.202480-1-salil.mehta@huawei.com/

Thanks

>  
>  thanks
>  -- PMM

WARNING: multiple messages have this Message-ID (diff)
From: Salil Mehta via <qemu-devel@nongnu.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
	"mst@redhat.com" <mst@redhat.com>,
	"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
	"Jonathan Cameron" <jonathan.cameron@huawei.com>,
	"alex.bennee@linaro.org" <alex.bennee@linaro.org>,
	"imammedo@redhat.com" <imammedo@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"gshan@redhat.com" <gshan@redhat.com>,
	"maz@kernel.org" <maz@kernel.org>,
	"will@kernel.org" <will@kernel.org>,
	"oliver.upton@linux.dev" <oliver.upton@linux.dev>,
	"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
	"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
	"david@redhat.com" <david@redhat.com>,
	"philmd@linaro.org" <philmd@linaro.org>,
	"andrew.jones@linux.dev" <andrew.jones@linux.dev>,
	"eric.auger@redhat.com" <eric.auger@redhat.com>,
	"npiggin@gmail.com" <npiggin@gmail.com>,
	"harshpb@linux.ibm.com" <harshpb@linux.ibm.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"darren@os.amperecomputing.com" <darren@os.amperecomputing.com>,
	"ilkka@os.amperecomputing.com" <ilkka@os.amperecomputing.com>,
	"vishnu@os.amperecomputing.com" <vishnu@os.amperecomputing.com>,
	"karl.heubaum@oracle.com" <karl.heubaum@oracle.com>,
	"miguel.luis@oracle.com" <miguel.luis@oracle.com>,
	 "salil.mehta@opnsrc.net" <salil.mehta@opnsrc.net>,
	zhukeqian <zhukeqian1@huawei.com>,
	"wangxiongfeng (C)" <wangxiongfeng2@huawei.com>,
	"wangyanan (Y)" <wangyanan55@huawei.com>,
	"jiakernel2@gmail.com" <jiakernel2@gmail.com>,
	"maobibo@loongson.cn" <maobibo@loongson.cn>,
	"lixianglai@loongson.cn" <lixianglai@loongson.cn>,
	"shahuang@redhat.com" <shahuang@redhat.com>,
	"zhao1.liu@intel.com" <zhao1.liu@intel.com>,
	Linuxarm <linuxarm@huawei.com>,
	"gustavo.romero@linaro.org" <gustavo.romero@linaro.org>
Subject: RE: [PATCH] arm/virt: Extract common code to wire GICC<->vCPU IRQs for reuse
Date: Wed, 6 Nov 2024 13:18:04 +0000	[thread overview]
Message-ID: <34aa0c9efb3144ab80a444144810b264@huawei.com> (raw)
In-Reply-To: <CAFEAcA9Jhz9a-X0B_bW++3kUePzTENJfq520A0CEst1o+QES4Q@mail.gmail.com>

HI Peter,

>  From: Peter Maydell <peter.maydell@linaro.org>
>  Sent: Wednesday, November 6, 2024 1:01 PM
>  To: Salil Mehta <salil.mehta@huawei.com>
>  
>  On Tue, 5 Nov 2024 at 22:20, Salil Mehta <salil.mehta@huawei.com> wrote:
>  >
>  > HI Peter,
>  >
>  > >  From: Peter Maydell <peter.maydell@linaro.org>
>  > >  Sent: Monday, November 4, 2024 1:27 PM
>  > >  To: Salil Mehta <salil.mehta@huawei.com>
>  > >
>  > >  On Sun, 3 Nov 2024 at 15:25, Salil Mehta <salil.mehta@huawei.com>
>  wrote:
>  > >  >
>  > >  > Extract common GIC and CPU interrupt wiring code to improve code
>  > > > readability and modularity, supporting reuse in future patch sets.
>  > >  > This refactor is benign and introduces *no* functional changes.
>  > >  >
>  > >  > Note: This patch has been isolated from a larger patch set to  >
>  > > facilitate early merging and reduce the complexity of the original
>  > > > set, as it operates independently. All original tags and author  >
>  > > contributions are retained.
>  > >
>  > >  I would prefer to see refactoring patches in the context of the
>  > > series that  makes them necessary. As it stands, there doesn't
>  > > really seem to be much  benefit to this change.
>  >
>  >
>  > Ok no issues. Just to confirm, your above comment is just specific to
>  > this patch or all the 3 individual patches I had sent for review?
>  
>  It applies to all of them (and as a general principle).


Got it. I thought changes in below patches were in any case useful as they were
improving the code?

https://lore.kernel.org/qemu-devel/20241103152256.202444-1-salil.mehta@huawei.com/
https://lore.kernel.org/qemu-devel/20241103152639.202480-1-salil.mehta@huawei.com/

Thanks

>  
>  thanks
>  -- PMM

  reply	other threads:[~2024-11-06 13:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-03 15:24 [PATCH] arm/virt: Extract common code to wire GICC<->vCPU IRQs for reuse Salil Mehta
2024-11-03 15:24 ` Salil Mehta via
2024-11-04 13:26 ` Peter Maydell
2024-11-05  0:13   ` Gavin Shan
2024-11-05 22:20   ` Salil Mehta
2024-11-05 22:20     ` Salil Mehta via
2024-11-06 13:00     ` Peter Maydell
2024-11-06 13:18       ` Salil Mehta [this message]
2024-11-06 13:18         ` Salil Mehta via
2024-11-05  0:33 ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34aa0c9efb3144ab80a444144810b264@huawei.com \
    --to=salil.mehta@huawei.com \
    --cc=alex.bennee@linaro.org \
    --cc=andrew.jones@linux.dev \
    --cc=darren@os.amperecomputing.com \
    --cc=david@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=gshan@redhat.com \
    --cc=gustavo.romero@linaro.org \
    --cc=harshpb@linux.ibm.com \
    --cc=ilkka@os.amperecomputing.com \
    --cc=imammedo@redhat.com \
    --cc=jean-philippe@linaro.org \
    --cc=jiakernel2@gmail.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=karl.heubaum@oracle.com \
    --cc=linux@armlinux.org.uk \
    --cc=linuxarm@huawei.com \
    --cc=lixianglai@loongson.cn \
    --cc=lpieralisi@kernel.org \
    --cc=maobibo@loongson.cn \
    --cc=maz@kernel.org \
    --cc=miguel.luis@oracle.com \
    --cc=mst@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=salil.mehta@opnsrc.net \
    --cc=shahuang@redhat.com \
    --cc=vishnu@os.amperecomputing.com \
    --cc=wangxiongfeng2@huawei.com \
    --cc=wangyanan55@huawei.com \
    --cc=will@kernel.org \
    --cc=zhao1.liu@intel.com \
    --cc=zhukeqian1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.