From: Dave Hansen <dave.hansen@intel.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: bp@alien8.de, dave.hansen@linux.intel.com, kernel-team@meta.com,
linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com,
riel@surriel.com, tglx@kernel.org, x86@kernel.org, xin@zytor.com
Subject: Re: [PATCH] x86/entry: Read CR2 in asm entry stub to redcue NMI clobbering window
Date: Thu, 14 May 2026 12:55:45 -0700 [thread overview]
Message-ID: <34cb5030-c62a-404b-b801-972840bb230b@intel.com> (raw)
In-Reply-To: <c1a61b27-8f33-44b4-84f6-e7256c1b5bdc@citrix.com>
On 5/14/26 12:49, Andrew Cooper wrote:
> Really, the NMI handler needs to preserve the registers it potentially
> clobbers, and that still requires the NMI handler doing it in assembly
> before entering C.
Yup, totally agree.
It's not rocket science, and it's what we do for CR3 because of PTI, but
it's also no fun. So I didn't want to suggest it.
I mean, we've lived with this behavior _forever_, right? So how bad
could it be?
next prev parent reply other threads:[~2026-05-14 19:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 16:12 [PATCH] x86/entry: Read CR2 in asm entry stub to redcue NMI clobbering window Rik van Riel
2026-05-13 16:31 ` Dave Hansen
2026-05-13 16:43 ` Rik van Riel
2026-05-13 17:12 ` Dave Hansen
2026-05-14 19:49 ` Andrew Cooper
2026-05-14 19:55 ` Dave Hansen [this message]
2026-05-14 18:09 ` kernel test robot
2026-05-14 22:54 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34cb5030-c62a-404b-b801-972840bb230b@intel.com \
--to=dave.hansen@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=riel@surriel.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.