From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
intel-wired-lan@lists.osuosl.org,
Donald Hunter <donald.hunter@gmail.com>,
Carolina Jubran <cjubran@nvidia.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [RFC PATCH v4] ethtool: add FEC bins histogramm report
Date: Mon, 11 Aug 2025 17:08:34 +0100 [thread overview]
Message-ID: <34da824b-1922-418f-953f-99287443b088@linux.dev> (raw)
In-Reply-To: <20250811084142.459a9a75@kernel.org>
On 11/08/2025 16:41, Jakub Kicinski wrote:
> On Sun, 10 Aug 2025 11:52:55 +0100 Vadim Fedorenko wrote:
>>> TBH I'm a bit unsure if this is really worth breaking out into
>>> individual nla_puts(). We generally recommend that, but here it's
>>> an array of simple ints.. maybe we're better of with a binary / C
>>> array of u64. Like the existing FEC stats but without also folding
>>> the total value into index 0.
>>
>> Well, the current implementation is straight forward. Do you propose to
>> have drivers fill in the amount of lanes they have histogram for, or
>> should we always put array of ETHTOOL_MAX_LANES values and let
>> user-space to figure out what to show?
>
> Similar logic to what you have, you can move the put outside of the
> loop, let the loop break or exit, and then @j will tell you how many
> entries to fill..
I see. Fair, I can do it. After this change there will be no need to
change the code in the reply size calculation, right?
WARNING: multiple messages have this Message-ID (diff)
From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Tariq Toukan <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>,
intel-wired-lan@lists.osuosl.org,
Donald Hunter <donald.hunter@gmail.com>,
Carolina Jubran <cjubran@nvidia.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH v4] ethtool: add FEC bins histogramm report
Date: Mon, 11 Aug 2025 17:08:34 +0100 [thread overview]
Message-ID: <34da824b-1922-418f-953f-99287443b088@linux.dev> (raw)
In-Reply-To: <20250811084142.459a9a75@kernel.org>
On 11/08/2025 16:41, Jakub Kicinski wrote:
> On Sun, 10 Aug 2025 11:52:55 +0100 Vadim Fedorenko wrote:
>>> TBH I'm a bit unsure if this is really worth breaking out into
>>> individual nla_puts(). We generally recommend that, but here it's
>>> an array of simple ints.. maybe we're better of with a binary / C
>>> array of u64. Like the existing FEC stats but without also folding
>>> the total value into index 0.
>>
>> Well, the current implementation is straight forward. Do you propose to
>> have drivers fill in the amount of lanes they have histogram for, or
>> should we always put array of ETHTOOL_MAX_LANES values and let
>> user-space to figure out what to show?
>
> Similar logic to what you have, you can move the put outside of the
> loop, let the loop break or exit, and then @j will tell you how many
> entries to fill..
I see. Fair, I can do it. After this change there will be no need to
change the code in the reply size calculation, right?
next prev parent reply other threads:[~2025-08-11 16:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 15:59 [Intel-wired-lan] [RFC PATCH v4] ethtool: add FEC bins histogramm report Vadim Fedorenko
2025-08-07 15:59 ` Vadim Fedorenko
2025-08-08 9:31 ` [Intel-wired-lan] " kernel test robot
2025-08-08 19:57 ` kernel test robot
2025-08-08 20:15 ` Jakub Kicinski
2025-08-08 20:15 ` Jakub Kicinski
2025-08-10 10:52 ` [Intel-wired-lan] " Vadim Fedorenko
2025-08-10 10:52 ` Vadim Fedorenko
2025-08-11 15:41 ` [Intel-wired-lan] " Jakub Kicinski
2025-08-11 15:41 ` Jakub Kicinski
2025-08-11 16:08 ` Vadim Fedorenko [this message]
2025-08-11 16:08 ` Vadim Fedorenko
2025-08-11 16:21 ` [Intel-wired-lan] " Jakub Kicinski
2025-08-11 16:21 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34da824b-1922-418f-953f-99287443b088@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=donald.hunter@gmail.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.